- 🇮🇳India rahul1707
I tested patch #3 on drupal 9.5.7 and drupal 10.0.3 and php 8.1 and found below error in Upgrade_status.
Call to undefined method Symfony\Component\HttpKernel\Event\ResponseEvent::isMasterRequest() in Drupal\ape\EventSubscriber\ApeSubscriber->onRespond()
Also patch #3 is not making module Drupal 10 compatible.
I have fixed these issues in new patch. Please review the patch.
Attached file with ignorable drupal-check errors.
Tested patch #5 on drupal 9.5.7 and drupal 10.0.7 and php 8.1 which is applied cleanly and working as expected, making it RTBC for latest D10 release..
- Status changed to RTBC
over 1 year ago 9:20am 28 April 2023 Rerolled patch #5 because the presence of the original
version: 8.x-1.0
is commented out when installed with composer.- First commit to issue fork.
- @thalles opened merge request.
- Status changed to Needs work
over 1 year ago 8:18am 13 July 2023 - 🇪🇸Spain navneet0693 Madrid
+++ b/ape_test/ape_test.info.yml @@ -1,6 +1,6 @@ +core_version_requirement: ^8 || ^9 || ^10
We should remove Drupal 8 support.
- First commit to issue fork.
- Status changed to Needs review
over 1 year ago 8:30am 13 July 2023 - Status changed to Needs work
over 1 year ago 9:54am 13 July 2023 - 🇪🇸Spain navneet0693 Madrid
@sakthi_dev One small suggestion, rest is good to go !
- Status changed to Needs review
over 1 year ago 11:54am 13 July 2023 - 🇪🇸Spain navneet0693 Madrid
I have added few more improvements at https://github.com/navneet0693/ape
- 🇺🇸United States steel-track
I am not doing much Drupal development these days so I am looking for a new maintainer of this module. If anyone is interested please reach out. Thanks!
- 🇺🇸United States steel-track
@codebymikey and @navneet0693: I've given you both maintainer permissions. Thank you for taking this on! If you have questions on the design of this module, feel free to ping me.
-
codebymikey →
committed 99d7dc82 on 8.x-1.x authored by
thalles →
Issue #3286083: Automated Drupal 10 compatibility fixes
-
codebymikey →
committed 99d7dc82 on 8.x-1.x authored by
thalles →
- Status changed to Fixed
about 1 year ago 3:03pm 19 September 2023 Automatically closed - issue fixed for 2 weeks with no activity.