Add revision log message when node translation has been deleted.

Created on 10 January 2024, 5 months ago
Updated 22 January 2024, 5 months ago

Problem/Motivation

There is no any revision log message, when node's translation deleted.

Steps to reproduce

1) Add a new language to the site.
2) Create a node.
3) Translate the node to a different language.
4) Try to delete the translation.

Proposed resolution

Add a revision log message, that translation was deleted.

โœจ Feature request
Status

Active

Version

11.0 ๐Ÿ”ฅ

Component
Entityย  โ†’

Last updated about 3 hours ago

  • Maintained by
  • ๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom @catch
  • ๐Ÿ‡จ๐Ÿ‡ญSwitzerland @Berdir
  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany @hchonov
Created by

๐Ÿ‡ง๐Ÿ‡พBelarus impol

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @impol
  • ๐Ÿ‡ง๐Ÿ‡พBelarus impol
  • Open in Jenkins โ†’ Open on Drupal.org โ†’
    Environment: PHP 8.1 & MariaDB 10.3.22
    last update 5 months ago
    25,796 pass, 1,838 fail
  • ๐Ÿ‡บ๐Ÿ‡ฆUkraine taraskorpach Lutsk
  • Merge request !6105Resolve #3413716 "Add revision log" โ†’ (Open) created by taraskorpach
  • Status changed to Needs work 5 months ago
  • ๐Ÿ‡บ๐Ÿ‡ฆUkraine taraskorpach Lutsk

    I've moved changes from #2 into a pull request, along with some enhancements.

    First, we need to verify whether the entity implements the RevisionLogInterface, and if so, use the common message instead of creating a unique one.

    Currently, I'm uncertain about the necessity for test coverage, as I am not very familiar with Drupal tests. Nevertheless, I'm adding the 'tests' tag as a precaution. I hope someone can assist with this.

  • Pipeline finished with Success
    5 months ago
    #75064
  • Pipeline finished with Success
    5 months ago
    #75402
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia pooja saraah Chennai

    pooja saraah โ†’ made their first commit to this issueโ€™s fork.

  • Pipeline finished with Success
    5 months ago
    #80865
  • Status changed to Needs review 5 months ago
  • ๐Ÿ‡บ๐Ÿ‡ฆUkraine taraskorpach Lutsk
  • Status changed to Needs work 5 months ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia djsagar

    Applied MR !6105 but not able to to any changes after applied.

    Steps to reproduce
    1) Add a new language to the site.
    2) Create a node.
    3) Translate the node to a different language.
    4) Try to delete the translation.

    moving NW

  • Pipeline finished with Running
    5 months ago
    #80911
  • Status changed to Active 5 months ago
  • ๐Ÿ‡บ๐Ÿ‡ฆUkraine taraskorpach Lutsk

    I've discovered that the revisionOverview function in the NodeController doesn't provide an opportunity to display revision messages in the list, due to the following condition:

    if ($revision->hasTranslation($langcode) && $revision->getTranslation($langcode)->isRevisionTranslationAffected()) {
    

    This raises a question: is this logic necessary at all? I need another opinion to confirm my thoughts.

Production build 0.69.0 2024