- Issue created by @impol
- last update
about 1 year ago 25,796 pass, 1,838 fail - Status changed to Needs work
about 1 year ago 2:21pm 10 January 2024 - ๐บ๐ฆUkraine taraskorpach Lutsk ๐บ๐ฆ
I've moved changes from #2 into a pull request, along with some enhancements.
First, we need to verify whether the entity implements the RevisionLogInterface, and if so, use the common message instead of creating a unique one.
Currently, I'm uncertain about the necessity for test coverage, as I am not very familiar with Drupal tests. Nevertheless, I'm adding the 'tests' tag as a precaution. I hope someone can assist with this.
- ๐ฎ๐ณIndia pooja saraah Chennai
pooja saraah โ made their first commit to this issueโs fork.
- Status changed to Needs review
about 1 year ago 3:38pm 22 January 2024 - Status changed to Needs work
about 1 year ago 4:42pm 22 January 2024 - ๐ฎ๐ณIndia djsagar
Applied MR !6105 but not able to to any changes after applied.
Steps to reproduce
1) Add a new language to the site.
2) Create a node.
3) Translate the node to a different language.
4) Try to delete the translation.moving NW
- Status changed to Active
about 1 year ago 5:25pm 22 January 2024 - ๐บ๐ฆUkraine taraskorpach Lutsk ๐บ๐ฆ
I've discovered that the
revisionOverview
function in theNodeController
doesn't provide an opportunity to display revision messages in the list, due to the following condition:if ($revision->hasTranslation($langcode) && $revision->getTranslation($langcode)->isRevisionTranslationAffected()) {
This raises a question: is this logic necessary at all? I need another opinion to confirm my thoughts.