The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇮🇳India pooja saraah Chennai
Fixed failed commands on #28
Attached patch against Drupal 10.1.x
Attached reroll patch - Status changed to Needs review
almost 2 years ago 5:19am 21 February 2023 - Status changed to Needs work
almost 2 years ago 8:38am 21 February 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
+ @trigger_error('MailFormatHelper::htmlToMailUrls() is deprecated in Drupal 8.5.0 and will be removed before Drupal 9.0.0. Instead, you should use \Drupal\Core\Mail\MailFormatHelper::htmlToTextUrls(). See https://www.drupal.org/node/2932899.', E_USER_DEPRECATED);
The deprecation message should mention Drupal 10 and Drupal 11, as the added comments do, for example the following one.
+ * @deprecated in drupal:10.1.0 and is removed from drupal:11.0.0. Instead, use + * \Drupal\Core\Mail\MailFormatHelper::htmlToTextUrls().
- 🇮🇹Italy apaderno Brescia, 🇮🇹
The last patch fixed what I reported in my previous comment. Let's see if the tests pass.