Deprecate locale_system_set_config_langcodes()

None of the usages in tests are necessary because the default language in these cases is en so it's doing absolutely nothing.

I don't think adding a test to call locale_system_set_config_langcodes () to prove the deprecation is worth it in this case.

The last submitted patch, 3: 3337900-3.patch, failed testing. View results →

I can confirm that this patch is working.
Applying both patches(parent and this one), it works.

Fixed the test I broke. It's good that \Drupal\Tests\locale\Kernel\LocaleConfigSubscriberForeignTest exists - unfortunately not real enough to have discovered 🐛 Installing a module causes translations to be overwritten Fixed but at least the inner workings of LocaleConfigSubscriber are tested with a different default language.

Posting screenshots of your codebase or command-line interface does not advance the issue, since the automated testing infrastructure tells us whether the change set still applies correctly.

So, I have not granted issue credit for that screenshot. In the future, you can get credit for issues by reading the issue to understand its purpose, and posting your review or testing of that purpose. Thank you!

The last submitted patch, 6: 3337900-6.patch, failed testing. View results →

Failure is unrelated but I'm curious why UserMailNotifyTest.php does not need replacement?

Not sure it needs deprecation test

@andypost UserMailNotifyTest doesn't have a different default language. This method only does something when that is true. UserMailNotifyTest adds other languages but it does not set them as a default.

Can we add a test case for the deprecation message.

I'm not convinced that a test is truly necessary but /shrug here one is - and at least it tests the functionality. Testing the message is probably the least important part - testing that we have not broke the functionality (and don't while the method is still around) is the one reason in favour of adding tests like this.

Gotcha. Been under the mindset that deprecation should always have tests. Got a good rule of thumb for when that's not the case?

Build errors on the patch.

Fixed CCF failed.

It's 10.2 target, makes sense to update patch

Replaced the deprecated function call locale_system_set_config_langcodes() with the suggested replacement \Drupal\locale\LocaleConfigManager::updateDefaultConfigLangcodes()
These changes should ensure compatibility with Drupal 11.0.0 while addressing the deprecation warnings.
Attached patch against Drupal 11 and interdiff file.

Please open mr and deprecation should ne in 10.3.0

Please open mr and deprecation should ne in 10.3.0

prem suthar → made their first commit to this issue’s fork.

prem suthar → changed the visibility of the branch 3337900- to hidden.

Re-rolled the patch As per #20 and as per the #19 updated the version from 10.3.1 to 10.3.0.

Please review the MR !11274 .

Left comments on the MR

@prem suthar thanks for rerolling but typically is advised when rerolling to also review the MR too as things or numbers need to be updated.

Thanks.

@smustgrave please review the changes .

Still has open threads.