The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
almost 2 years ago 1:09pm 6 February 2023 - 🇮🇳India pooja saraah Chennai
Fixed failed commands on #11
Attached patch against Drupal 10.1.x - Status changed to Needs work
almost 2 years ago 1:37pm 7 February 2023 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
over 1 year ago 9:34am 1 May 2023 - last update
over 1 year ago 29,369 pass - 🇳🇱Netherlands arantxio Dordrecht
I've adjusted the patch to fix the custom commands failing.
- last update
over 1 year ago 29,369 pass - last update
over 1 year ago 29,369 pass - last update
over 1 year ago 29,369 pass - 🇳🇱Netherlands arantxio Dordrecht
Moved the code I set in HandlerBase to ArgumentPluginBase as this is directly used by the StringArgument class. This way it doesn't get set for all classes extending the HandlerBase.
- last update
over 1 year ago 29,369 pass - last update
over 1 year ago 29,369 pass - last update
over 1 year ago 29,369 pass - 🇳🇱Netherlands arantxio Dordrecht
It is better to do it in the class it is actually used in, here's a updated patch.
- last update
over 1 year ago 29,369 pass - last update
over 1 year ago 29,369 pass - 🇳🇱Netherlands daffie
All code changes look good to me.
The IS and the CR are in order.
For me it is RTBC. - last update
over 1 year ago 29,376 pass - last update
over 1 year ago 29,380 pass - last update
over 1 year ago 29,381 pass - last update
over 1 year ago 29,382 pass - last update
over 1 year ago 29,385 pass - last update
over 1 year ago 29,390 pass - last update
over 1 year ago 29,390 pass - last update
over 1 year ago 29,390 pass - last update
over 1 year ago 29,390 pass - last update
over 1 year ago 29,384 pass, 2 fail - last update
over 1 year ago 29,383 pass, 1 fail - last update
over 1 year ago 29,397 pass - last update
over 1 year ago 29,401 pass - last update
over 1 year ago 29,378 pass, 2 fail - last update
over 1 year ago 29,402 pass 48:27 45:07 Running- last update
over 1 year ago 29,415 pass - last update
over 1 year ago 29,417 pass - last update
over 1 year ago 29,422 pass - last update
over 1 year ago 29,422 pass - last update
over 1 year ago 29,427 pass - last update
over 1 year ago 29,431 pass - Status changed to Needs work
over 1 year ago 12:41pm 16 June 2023 - 🇬🇧United Kingdom longwave UK
This looks OK, but there is also Drupal\views\Plugin\views\query\SqliteDateSql - is there an issue to move this, and I wonder if it's worth having a single backend-overridable Views database service instead of multiple services?
Two nits:
-
+++ b/core/modules/pgsql/src/Plugin/views/argument/ArgumentStringService.php @@ -0,0 +1,31 @@ + * Database neutral implementation of the service "views.argument_string".
This class isn't database neutral.
-
+++ b/core/modules/sqlite/src/Plugin/views/argument/ArgumentStringService.php @@ -0,0 +1,32 @@ + * Database neutral implementation of the service "views.argument_string".
Neither is this one.
-