Use a modal for content entity form delete links confirmation forms

Fixed failed commands on #64
Attached patch against Drupal 10.1.x

Changed the operations list to use modal for delete confirmation.

While I did that, I noticed similar issues that @bnjmnm reported on ✨ Use modals on the Manage Fields page Needs work where the focus moved to the window when returning from dialog because the button from toolbar is no longer focusable.

The last submitted patch, 66: 2254935-66.patch, failed testing. View results →

Agree this needs accessibility review as it provides a new popup functionality.

Tested #70
When the modal opens the focus goes to the "Delete" button - which is good
Tabbing does not leave the module. "Delete" button -> "Cancel" button -> X button in the corner - while is good

This is the markup of the modal

<div tabindex="-1" role="dialog" class="ui-dialog ui-corner-all ui-widget ui-widget-content ui-front ui-dialog-buttons" aria-describedby="drupal-modal" aria-labelledby="ui-id-1" 

role = dialog seems correct
aria-describedby and aria-labelledby are the ones I'm not 100% about.

Think accessibility

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

@smustgrave what are the aria-describedby="drupal-modal" and aria-labelledby="ui-id-1" describing?

These are usually very accurate:
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attribut...
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attribut...

These might be:
https://benmyers.dev/blog/aria-labels-and-descriptions/
https://cccaccessibility.org/web-1/web-developer-tutorials/aria-labelled...

This issue is confusingly similar to 📌 Use a modal for entity delete operation links Fixed . While this is intended for content entities and the other for config entities, there is not currently a split implementation between the two. Both content and config entities rely on \Drupal\Core\Entity\EntityForm, and the code changes on the two issues are almost identical. The only difference is test coverage.

Since this is the "newer" issue and the other one has a more recently updated MR, I'm going to mark this as a duplicate. I will transfer contribution credit over to the other issue.

Thanks @tim.plunkett

From both a code maintainability and usability perspective, the more consistency we have across the admin UI the better.