- 🇺🇸United States smustgrave
+ public function testUpdateHookN() { + $this->runUpdates(); + $this->assertEqualLayoutSectionDataType('longblob'); + }
Can we add an assertion before the updates run. To test for what it is now.
- 🇮🇳India pooja saraah Chennai
Addressed the Comment #55
Attached patch against Drupal 10.1.x - Status changed to Needs review
over 1 year ago 8:20am 17 February 2023 - Status changed to Needs work
over 1 year ago 12:32pm 17 February 2023 - 🇬🇧United Kingdom catch
#56 isn't quite doing what #55 asked for, but it also shows that the test isn't testing what it thinks it is, since it'll pass even without the update running.
- Status changed to Needs review
over 1 year ago 3:43am 5 April 2023 - 🇮🇳India rckstr_rohan
Addressed #55 adding an assertion after to the check the expected value after test run.
- Status changed to Needs work
over 1 year ago 1:34pm 5 April 2023 - 🇺🇸United States smustgrave
Per #58 the tests should be looked at as they don't appear to be testing what's expected.
- Status changed to Needs review
over 1 year ago 2:12am 6 April 2023 - 🇮🇳India rckstr_rohan
hii, The above patch failed because the branch has been updated with file layout-builder.php, so removing the file from the patch and adding assertion after to the check the expected value after test run, addressed #55.
indiff is same as #60
The last submitted patch, 62: 3030154-62.patch, failed testing. View results →
- Status changed to Needs work
about 1 year ago 12:45pm 24 August 2023 - 🇧🇪Belgium weseze
Patch #42 works very well for us on D9.5.
We are using a heavily customized layout builder setup though.
It contains inline block_content for section configuration through https://www.drupal.org/project/layout_block →
It also contains a few dozen block_content types for actual section content.
All of these blocks have 50+ fields on them. (some of them coming close to 100 fields)
We only had issues when using the section_library module. Related issue that reference me here: https://www.drupal.org/project/section_library/issues/3232071 → - 🇮🇹Italy finex
Hi, could this patch considered as "safe" for production environment or is still under development? Thank you very much.
- 🇺🇸United States pyrello
@FiNeX FWIW, we've been using this in production for a while now and I would consider it safe.