- Status changed to Needs work
almost 2 years ago 9:22pm 13 February 2023 - πΊπΈUnited States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request β as a guide.
For the specific test coverage still needed.
Also I see that the tests were updated is that because this attribute is now required? Won't this break existing sites that don't have it?
- First commit to issue fork.
- Status changed to Needs review
10 months ago 6:14am 8 March 2024 - π³πΏNew Zealand danielveza Brisbane, AU
Opened an MR with a slightly different approach.
The existing patch will add an ID to every since block that is added via LB, which feels a bit overkill to solve this. Instead I've added a default ID that will be applied to system_menu_blocks if one does not exist. If people like this approach I'll add some tests
- Status changed to Needs work
10 months ago 6:24am 8 March 2024 The Needs Review Queue Bot β tested this issue.
While you are making the above changes, we recommend that you convert this patch to a merge request β . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
- Status changed to Needs review
9 months ago 6:34am 25 March 2024 - Status changed to Needs work
9 months ago 1:34pm 25 March 2024 - πΊπΈUnited States smustgrave
Seems a few other block--system-menu-block.html.twig in core. Is there a place we can add an assertion to?