Contrib.social

"Unsaved Changes" messaging in Off-Canvas dialogs needs to be consistent.

Open on Drupal.org →
Created on 21 March 2019, about 5 years ago
Updated 9 April 2024, about 2 months ago

Problem/Motivation

(This issue's component is currently Layout Builder but it's very possible it may move elsewhere)

This comes out of #2995689: Allow reordering blocks without a pointer device → . The issue includes a tabledrag-using form inside an off-canvas dialog. When a table row is dragged to a new position, tabledrag adds a "You have unsaved changes" warning to alert users that the changes they make are not automatically saved.

This warning is not present in the Dialog when any other changes are made, even though these changes are not automatically saved either. To avoid giving users the false impression that their changes in the Dialog are automatically saved, the "You have unsaved changes" warning has been hidden with css using display: none;.

Proposed resolution

Determine if it's preferable to add "unsaved changes" messages to Dialogs anytime a needs-saving change is made, or if modifications should be made to Tabledrag so the message can be suppressed more elegantly when needed.

Remaining tasks

First determine the best approach based on the problem and proposed resolution's described above.

User interface changes

TBD

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

📌 Task
Status

Active

Version

11.0 🔥

Component
Layout builder  →

Last updated about 12 hours ago

Created by

🇺🇸United States bnjmnm Ann Arbor, MI

Live updates comments and jobs are added and updated live.
  • Blocks-Layouts

    Blocks and Layouts Initiative. See the #2811175 Add layouts to Drupal issue.

  • Usability

    Makes Drupal easier to use. Preferred over UX, D7UX, etc.

  • Accessibility

    It affects the ability of people with disabilities or special needs (such as blindness or color-blindness) to use Drupal.

  • Needs screenshots

    The change alters the user interface, so before and after screenshots should be added to document the UI change. Make sure to capture the relevant region only. Use a tool such as Aviary on Windows or Skitch on Mac OS X.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment about 2 months ago →
    🇳🇿New Zealand DanielVeza Brisbane, AU

    Coming at this from a Layout Builder point of view.

    In my opinion we should hide the "You have unsaved changes" from components using the tabledrag library when we are in the Layout Builder context. It doesn't really add any value and makes it quite confusing as it gives the impression that other changes are saved automatically. It could lead people to wonder why they don't get that message when they change a select list item or type in CKEditor, is that saved automatically?

    In terms of hiding this, adding .layout-builder-configure-block .tabledrag-changed-warning { display: none } in Layout Builder should be enough to hide instances of this, if people agree with my points above.

  • Comment about 2 months ago →
    🇳🇿New Zealand DanielVeza Brisbane, AU

    makes it quite confusing as it gives the impression that other changes are saved automatically. It could lead people to wonder why they don't get that message when they change a select list item or type in CKEditor, is that saved automatically?

    Adding another screenshot that I feel illustrates this point better

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024