- 🇧🇷Brazil carolpettirossi Campinas - SP
I'm wondering how I can provide a patch here, and any guidance would be appreciated.
Should we get a
ScrollTopCommand
into Core (9.x)? I've seen this issue https://www.drupal.org/project/drupal/issues/3300481 ✨ Move ScrollTopCommand views Ajax command to the Drupal Core Fixed that might help with this part.After getting a
ScrollTopCommand
in Core, is updating theAjaxFormHelperTrait::ajaxSubmit
the correct solution for this issue? - 🇧🇷Brazil carolpettirossi Campinas - SP
Providing a patch to fix the
scrollTop
with Ajax submission in Layout Builder. The patch attached is for 9.5.x.The approach is to override the
AjaxFormHelperTrait::ajaxSubmit
inConfigureBlockFormBase
, calling a custom/new Ajax command calledLayoutBuilderScrollTopCommand
responsible for scrolling the LB canvas to top.Before:
After:
layout - Status changed to Needs review
over 1 year ago 3:42pm 22 March 2023 - Status changed to Needs work
over 1 year ago 4:07pm 22 March 2023 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- last update
7 months ago Patch Failed to Apply