Move ScrollTopCommand views Ajax command to the Drupal Core

Murz → closed merge request !2718

I've rebased the changes on 10.1.x branch - please review.

I apologize I should of added in #7 but can you update the issue summary for the proposed solution.

Reviewing the code I left 1 comment but since it's generic not sure what the standard is there. Know with new functions in D10 they would like them typehinted.

Everything else looks good to me.

I've fixed up the code by the last remark, and have updated the issue summary.

Open threads were resolved.

Left some comments on the MR.

Moving to NW to address the comments in MR.

Thanks, I've fixed all by remarks, also have added a change record: https://www.drupal.org/node/3344141 → - please review.

Seems to have a CI failure

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Fixed code style errors.

Seems all points have been resolved. Lets see what the committers think.

lauriii → closed merge request !3412

Committed 5030f45 and pushed to 10.1.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.