Layout selection weight sorting

Just ran into this issue here: ✨ Use weight to sort the layouts Active

Weight is essentially needed and we should add it. I'll add it as TODO and hope we can finally finish this one ;)

I manually applied patch "3089418-22.patch" on the issue branch.

Grevil → closed merge request !4944

All done! I hope the provided test changes suffice! Failing tests seem to be unrelated! See 🐛 strnatcasecmp(): Passing null to parameter #2 ($string2) of type string is deprecated Needs work , for a similar issue.

Never mind, there are also failing tests related to this issue.

Alright, now it should be fixed.

@Grevil: Still 6 failing tests here.

As mentioned in #32, they seem unrelated.

Have not yet reviewed or tetsed

But seems to have some test failures.

Usually there's just 1 random failure but 6 consistently means the MR is causing them. If they're fixed in 🐛 strnatcasecmp(): Passing null to parameter #2 ($string2) of type string is deprecated Needs work then this should be postponed as it can't be merged with failures.

Thank you, @smustgrave! I'll take a deeper look later on. The test failures are also very consistent, even after rebasing, so it probably is somehow related to the changes here.

@smustgrave #37 references an unrelated issue with the same error. I just ran into exactly this issue in LayoutPluginManager.
We need a separate, but similar issue as referenced in #37 but for LayoutPluginManager!

Here are other similar issues:
🐛 Shortcut links without a title cause deprecation notices. Needs work
#3306453: Resolve Deprecated function: strnatcasecmp(): Passing null to parameter #2 →

@Grevil could you please open an issue to fix getSortedDefinitions() in LayoutPluginManager?
Seems it just needs ?? '' or casting to (string)

Here's the correct issue: 🐛 Add missing category to Drupal\layout_builder\Plugin\Layout\BlankLayout and let modules and themes alter the list of layouts RTBC

Please review 🐛 Add missing category to Drupal\layout_builder\Plugin\Layout\BlankLayout and let modules and themes alter the list of layouts RTBC to get it merged asap so we can proceed here :)