alexpott → credited Webbeh → .
Unassigned for review. Moved 'Critical' to 'Major' per priority descriptions/usages.
This issue is a mess given the lack of collaboration. I recommend closing this and fixing it internally.
composer require drupal/inline_entity_form:^1 should do it.
Logged an issue with GovCMS per #6: https://github.com/govCMS/GovCMS/issues/922
@roshni27 a patch file and screenshots are unnecessary since we were working in a MR/fork, and I worry this was done for credit-gaming.
Why did you create two patches from the MR?
See 🌱 ckeditor_font merging with ckeditor5_font, colorbutton Active for consolidation efforts, which sadly did not go anywhere.
Good call. Closing. Thanks.
We should probably do something about legacy maintainers, as many of the folks listed (like myself!) no longer support this project. I'll leave that to the new team to do.
You've all been given access. Appreciate your work to bring contrib to life.
I'm okay with each of you being added. I'm going to go ahead and process that ASAP.
Time keeps on slipping.
Updating title for revised date.
What's the dif between comment #2? Is there one?
NW because I suspect a drive-by patch effort rather than building off the work done in the issue thus far.
Follow-up issue created: ✨ Pass on desgination redirect when ignoring form redirects' ?destination query parameter Active
Webbeh → created an issue.
The default 'Section #' only appears if a section lacks a user-provided label. I think it makes sense to keep them numbered based on how they are stacked on the page at the time you are re-ordering sections, otherwise it becomes a meaningless label.
One option might be to make clearer these are automatically named because they have no label (e.g. 'Unnamed Section #'), but I realize the Layout tray width is troublesome.
I've moved into a new role that does not do Drupal development, so unassigning.
I'll set up a comaintainer request issue to bring new life into this module.
Webbeh → created an issue.
A reroll patch request does not constitute a priority update to Major.
As a reminder, to fix this, we need to find a reproducible process to recreate this issue.
The steps should begin with: install Drupal using a default profile, install version 2.0.0, then upgrade, and see error; or, to find a process that reproduces this.
What does the patch in #34 do? How is it different than #31? Can you provide any context to what the patch fixes?
Committed - thanks.
Please include interdiffs when creating a new patch, or use the fork/MR functionality so folks can easily follow what changes have been made between contributions. Thanks!
Based on #9, moving to Needs Work.
Given the work done in #32, removing "Needs Tests" tag. For Review.
Since we are now adjusting this work on 3.0.x (from #29-on), changing version tag.
Please read the issue before contributing.
Removing files uploaded in #39 (and other, non-interdiff patches) because, to reiterate again:
As a friendly reminder, please post interdiffs between patches if you're conducting meaningful work, so maintainers and other users can understand the changes.
Frankly, I recommend closing this issue as "Will Not Fix" and handling these outside of an issue, as this issue is largely a drive-by patch effort rather than coordinated efforts.
Appreciate the feedback.
Before I cut a new release, please let me know this works and I'll release -beta3.
Oops. I should have double checked, let me push a new release and fix. Thanks again for your patience.
Thanks for beta testing. This is very good to hear, rolling out a fix momentarily and getting a new release out.
Updated comment above to reference https://www.drupal.org/node/3264983 → as a possible strategy.
Committed for D10 compatibility. Keeping open for new patches.
Thanks for the feedback, #3. Patch looks fine, so I'll commit.
Seems like an easy enough thing for someone to test, and as long as it works, I can commit it.
Unassigning, as it's been 2 years.
Upgrading to Major.
Unassigning, and I recommend not providing contribution credit to @himanshu_jhaloya.
I believe that [#3264983] may solve the issue, but I'm checking in the #ckeditor5 channel in Drupal Slack to check the right way forward.
Given 📌 Incorporate translations support into the starter template Active , I'm curious if this is a larger issue across CKE5 contrib space, but I'll let you know what I hear back.
Don't judge - I'm awful with GitLab UI for pushing to a branch. Fix in field description in place. Thanks.
Ah, let me make sure I understand, because I believe the IS is missing a key context.
Right now, hsl is looking for hsl(0,0,0)|Color, but you need hsl(0,0%,0%)|Color (the inclusion of percentages for second and third parameters), correct?
I appreciate your research into this and feedback. Adding credit for findings, and noting this is a core CKE5 issue and not applicable to this issue, so I'm extra happy to hear that!
Very good find - looks like an easy fix as well. I'll queue it up in my workload to knock out.
Appreciate the follow-up issues - let's get those squashed! Thanks!
Fixed, but awkward rejection will need to be fixed. Marking as open for new patches as needed.
README actually needs instructions updated for 1.x and 2.x. Given this, I'd rather see work go towards that than a simple Markdown conversion in attempts to boost the Drupal.org credit system. Closing this for now, I suggest anyone interested in documentation please create an issue towards updating the documentation content, not formatting.
Active for new patches.
Fixed. Thanks.
Putting out an early release for this, now with D10 support added.
MR9 merged. Let's get this party started.
Apologies for the delay in moving this forward, I've taken on a new role that has moved me away from Drupal as my primary duties, and my organization does not have a colleague interested in comaintainership at this time.
Given the lack of additional context and the request for RTBC, I'm going to move it to RTBC, commit, and release an early D10-compatible release. Thank you all for your feedback, guidance, and help in getting this moving forward.
Mark Fullmer is incredible - so glad to hear. Thanks for following up.
Would be awesome to pair this with #3209012: Move to eluceo/ical 2.0 → so both of these modules can be intercompatible.
This is a duplicate of #3209012: Move to eluceo/ical 2.0 → .
RE #37: we now have a MR and continued patching. Since we have a MR and fork for the issue (#36), please contribute there instead. Mixing up patches and MRs (for the sake of getting semi-automatic issue credit, for example) makes it harder to reconcile the two solution paths.
Per #3134371-11: Allow changing the layout of an existing section in Layout Builder UI → , providing a well-needed issue summary update.