- Issue created by @Webbeh
- 🇺🇸United States Chris Burge
In terms of scope, are the following items, provided Layout Builder Operation Link, in scope?
- Accommodation of translations (e.g. Layout Builder Asymmetric Translation)
- Removal the destination query parameter that is hardcoded by Drupal\views\Plugin\views\field\EntityOperations::render()
My vote on the first is yes, because if we don't, then we'll still have a need for contrib module.
My vote on the second is yes, because it's a bug workaround. - Assigned to Chris Burge
- Merge request !4324Issue #3368656: Add 'Layout' Operation Link to entities → (Open) created by Chris Burge
- last update
over 1 year ago Build Successful - last update
over 1 year ago 29,799 pass - Issue was unassigned.
- Status changed to Needs work
over 1 year ago 9:31pm 5 July 2023 - 🇺🇸United States Chris Burge
Initial copying from the layout_builder_operation_link module is complete.
Re
layout_builder_install()
, in order to rebuild operation links, the rendered cache needs cleared unconditionally. The same is true in the newly addedlayout_builder_uninstall()
function.layout_builder_post_update_rerender_operation_links()
is added to clear cache (again, to rebuild operation links).In the layout_builder.module file, two new functions are added:
layout_builder_entity_operation()
andlayout_builder_preprocess_links()
. I added them to the end of the file.The
OperationLinkTest
class provides test coverage. Right now,testLanguage()
returns before doing anything. It relies on a contrib module (layout_builder_at), so it'll need rewritten to remove the contrib test dependency.Setting issue status to 'Needs work' for test coverage.
- 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Left a review even though this is still needs work, thanks for working on it!
- First commit to issue fork.
- last update
over 1 year ago 30,062 pass - 🇦🇺Australia acbramley
Rebased and resolved the minor feedback + minor tidy ups. Not sure how to go about the language stuff though.