- Merge request !1Issue #3118327: drupal-ckeditor-libraries-group composer installation support โ (Merged) created by voleger
- ๐บ๐ธUnited States Webbeh Georgia, USA
Why did you create two patches from the MR?
- ๐ฎ๐ณIndia praveenpb Bangalore
@Webbeh, I thought to update the patch file name so uploaded a second one but I already removed the first one from display.
- ๐ง๐ฌBulgaria pfrenssen Sofia
@praveenpb FYI it's not needed to manually create patches from the MR, you can directly link to the auto-generated patch: https://git.drupalcode.org/project/fakeobjects/-/merge_requests/1.diff - see the "plain diff" link in the MR section above.
- ๐ฎ๐ณIndia praveenpb Bangalore
@pfrenssen, The problem of using auto-generated patch is that it changes whenever someone pushed something to the MR, and it will be applied to our project when we run composer install/update without our knowledge. If someone pushes a buggy code it is not safe to use it, but if you create a patch manually, it will not change that patch.
- ๐ง๐ฌBulgaria pfrenssen Sofia
@praveenpb fair enough, but you can just commit it locally in your project if you want to pin a specific version of a MR, or use the branch from the issue fork directly and pin the commit in composer.json.
- First commit to issue fork.
-
xmacinfo โ
committed 31878af4 on 8.x-1.x authored by
voleger โ
Issue #3118327: drupal-ckeditor-libraries-group composer installation...
-
xmacinfo โ
committed 31878af4 on 8.x-1.x authored by
voleger โ
- ๐จ๐ฆCanada xmacinfo Canada
I was not able to try this to check if the package was downloaded to the library folder instead of the vendor folder before doing the commit. I faced a catch-22. Information on proper testing that type of composer.json changes would be appreciated.
However, this change looks a straightforward change so I did the commit.
- ๐จ๐ฆCanada xmacinfo Canada
Tested the dev branch successfully.
composer require 'drupal/fakeobjects:1.x-dev@dev' ./composer.json has been updated Running composer update drupal/fakeobjects > DrupalProject\composer\ScriptHandler::checkComposerVersion Loading composer repositories with package information Updating dependencies Lock file operations: 2 installs, 0 updates, 0 removals - Locking drupal-ckeditor-libraries-group/fakeobjects (4.22.1) - Locking drupal/fakeobjects (dev-1.x 31878af) Writing lock file Installing dependencies from lock file (including require-dev) Package operations: 2 installs, 0 updates, 0 removals - Syncing drupal/fakeobjects (dev-1.x 31878af) into cache - Installing drupal-ckeditor-libraries-group/fakeobjects (4.22.1): Extracting archive - Installing drupal/fakeobjects (dev-1.x 31878af): Cloning 31878af419 from cache
$ libraries ls fakeobjects
After enabling the module, the Status Reports displays:
FakeObjects Plugin detected
Automatically closed - issue fixed for 2 weeks with no activity.