- πΊπΈUnited States Webbeh Georgia, USA
Apologies for the delay in moving this forward, I've taken on a new role that has moved me away from Drupal as my primary duties, and my organization does not have a colleague interested in comaintainership at this time.
Given the lack of additional context and the request for RTBC, I'm going to move it to RTBC, commit, and release an early D10-compatible release. Thank you all for your feedback, guidance, and help in getting this moving forward.
- Status changed to Fixed
almost 2 years ago 1:30pm 28 February 2023 - πΊπΈUnited States Webbeh Georgia, USA
MR9 merged. Let's get this party started.
- π§πͺBelgium redseujac
Installed version 2.0.0.-beta1 on Drupal 10.0.4.
Same comments as in #63.
Apart from that working fine.
However a couple of little issues:
- Buttons are not translatable: see https://www.drupal.org/project/ckeditor_font/issues/3346729 π Buttons are not translatable Fixed
- Wrong syntax for hsl color values: see https://www.drupal.org/project/ckeditor_font/issues/3346485 π Wrong syntax for hsl color values Fixed
- πΊπΈUnited States Webbeh Georgia, USA
Appreciate the follow-up issues - let's get those squashed! Thanks!
- π§πͺBelgium redseujac
You're welcome! But don't forget the issues reported by smustgrave in #63. I can confirm these.
- π§πͺBelgium redseujac
smustgrave commented in #63:
I think this is a bug with ckeditor but when I highlight text and change the font size. Press enter to go to the next line. That font is still being used. Verified with other buttons too.
I tested with some basic CKEditor 5 buttons (such as Underline, Italic, Bold) and they are also causing the same issue: highlight text and change the font property (Underline/Italic/Bold). Press enter to go to the next line. That font property is still being used.
So, finally it's a CKEditor 5 issue that should be fixed. Can someone report this under CKEditor 5 issues?
- πΊπΈUnited States Webbeh Georgia, USA
I appreciate your research into this and feedback. Adding credit for findings, and noting this is a core CKE5 issue and not applicable to this issue, so I'm extra happy to hear that!
- π§πͺBelgium redseujac
smustgrave commented in #63:
Enabling all the buttons.
As I'm filling in the font values "Font background colors" is showing as error even though I haven't filled anything inI assume this is not a bug.
When the "Font background color" button is activated (= dragged to the bar with active buttons), at least one valid color value must be entered in the box "Font background colors" before saving, otherwise it doesn't make sense => button activated without any color value assigned.
It seems easy enough to copy and paste (all) the color values from the box "Font colors".
Automatically closed - issue fixed for 2 weeks with no activity.