- Merge request !778Issue #3003610: Remove block.module dependency from Layout Builder → (Closed) created by tim.plunkett
- First commit to issue fork.
- Open on Drupal.org →Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Not currently mergeable. - Status changed to Needs review
over 1 year ago 9:37am 2 November 2023 - 🇮🇳India bhanu951
Rebased the MR to latest 11.x Head and fixed Merge Conflicts.
- Status changed to Needs work
over 1 year ago 2:18pm 2 November 2023 - 🇺🇸United States smustgrave
Seems to have failures. Also still need a change record.
- First commit to issue fork.
- Merge request !12313Issue #3003610: Remove block.module dependency from Layout Builder → (Open) created by acbramley
- 🇦🇺Australia acbramley
https://git.drupalcode.org/project/drupal/-/merge_requests/778 had conflicts in almost every file + the changes to theme hooks and preprocess made this impossible to rebase. I've started a fresh branch here https://git.drupalcode.org/project/drupal/-/merge_requests/12313
I don't think moving the template_preprocess_block and preprocessBlock functions will cause any issues.
- 🇦🇺Australia acbramley
acbramley → changed the visibility of the branch 3003610-block to hidden.
- 🇦🇺Australia acbramley
I've tested having the theme hook in both modules and I don't think it's going to work because the theme registry does this:
$cache = NestedArray::mergeDeep($cache, $result);
Which merges both definitions together, meaning the system definition will override the block definition but keep the deprecation message.I also tested just keeping the template around in block module without the theme hook and tests still pass when other templates use
@block/block.html.twig
but then we have no way of throwing the deprecation.