Contrib.social

Remove block.module dependency from Layout Builder

Open on Drupal.org →
Created on 1 October 2018, over 6 years ago
Updated 2 November 2023, over 1 year ago

Problem/Motivation

\Drupal\Core\Block provides the entire block plugin system.
block.module provides the Block UI (admin/structure/block) used to place instances of those block plugins into theme regions

layout_builder.module uses block plugins as well, but has nothing to do with theme regions or per-theme block placements.

Yet it has a hard dependency on block.module for (at least) two reasons:

  1. It uses '#theme' => 'block' for it's output, which is provided by block.module instead of by system.module
  2. While waiting for #2936655: Layout Builder should use the toolbar modes system once it exists. → , Layout Builder adopted local tasks for navigation, which are provided by a theme-based block

Proposed resolution

Move the block template and theme hook from block.module to system.module
Wait for a non-local-task based approach for navigation

Remaining tasks

Restore block.html.twig in Block module but with a deprecation

User interface changes

API changes

Data model changes

📌 Task
Status

Needs work

Version

11.0 🔥

Component
Layout builder  →

Last updated 3 days ago

Created by

🇺🇸United States tim.plunkett Philadelphia

Live updates comments and jobs are added and updated live.
  • Blocks-Layouts

    Blocks and Layouts Initiative. See the #2811175 Add layouts to Drupal issue.

  • Needs change record

    A change record needs to be drafted before an issue is committed. Note: Change records used to be called change notifications.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • Open on Drupal.org →
    Environment: PHP 8.1 & MySQL 5.7
    last update over 1 year ago
    Not currently mergeable.
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇮🇳India bhanu951

    Rebased the MR to latest 11.x Head and fixed Merge Conflicts.

  • Status changed to Needs work over 1 year ago
  • Comment over 1 year ago →
    🇺🇸United States smustgrave

    Seems to have failures. Also still need a change record.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024