Callers of LayoutEntityHelperTrait::getEntitySections() do not account for the view mode

Created on 24 October 2018, about 6 years ago

Updated 5 July 2024, 6 months ago

Problem/Motivation

Once ✨ Consider supporting Layout Builder Overrides for other view modes Needs work is addressed, sections will be stored per-view mode.

LayoutEntityHelperTrait::getEntitySections() assumes the view mode is default.

Proposed resolution

Provide additional functionality for displays, and do not assume the default display.

Remaining tasks

Per #3008924-27: Callers of LayoutEntityHelperTrait::getEntitySections() do not account for the view mode → :

Thank you all! Sadly still needs tests and steps to reproduce to be committed. I don't have the time currently, sorry.

Steps to reproduce should follow, per #3008924-13: Callers of LayoutEntityHelperTrait::getEntitySections() do not account for the view mode → :

Could you explain how to reproduce the bug, using only core modules?
Step by step, starting with "Install standard profile"
That is an important step for writing test coverage, which must be done before the fix can be committed.

User interface changes

N/A

API changes

TBD

Data model changes

N/A

🐛 Bug report

Status

Needs work

Version

11.0 🔥

Component

Layout builder →

Last updated 2 days ago

Maintained by
🇺🇸United States @tedbow
🇺🇸United States @dyannenova
🇺🇸United States @tim.plunkett

Created by

🇺🇸United States tim.plunkett Philadelphia

Live updates comments and jobs are added and updated live.

Blocks-Layouts
Blocks and Layouts Initiative. See the #2811175 Add layouts to Drupal issue.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Needs steps to reproduce

Needs Review Queue Initiative
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Status changed to Needs work almost 2 years ago3:30pm 14 February 2023
Comment almost 2 years ago →
🇺🇸United States smustgrave
Did not test

But for the tests and steps to reproduce.
Comment about 1 year ago →
🇨🇦Canada joelpittet Vancouver
We've been using #33 for a while. Thanks for rerolling @andypost.

Sorry I don't have any steps on this one, but my guess it has to do with our entity references to field_bundle/storage entities in LB.
Comment 6 months ago →
🇧🇷Brazil carolpettirossi Campinas - SP
I have faced an issue that I needed to add patch #42 + patch from https://www.drupal.org/project/layout_builder_st/issues/3069964 → when using the modules "Moderation Dashboard" and accessing the /user/{uid}/moderation-dashboard page.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024