LayoutEntityHelperTrait::isLayoutCompatibleEntity() should check whether the entity type has a view builder class

Created on 7 May 2019, over 5 years ago
Updated 30 January 2024, 11 months ago

Problem/Motivation

\Drupal\layout_builder\LayoutEntityHelperTrait::isLayoutCompatibleEntity() is invoked on every entity presave by \Drupal\layout_builder\InlineBlockEntityOperations::handlePreSave(), and the code for checking layout_builder compatibility is quite expensive and involves creating contexts and whatnot.

Proposed resolution

Entity types that don't have a view builder handler (most config entities) can never be managed by Layout Builder, so we should add check for that.

Remaining tasks

Review.

User interface changes

Nope.

API changes

Nope.

Data model changes

Nope.

Release notes snippet

Nope.

πŸ“Œ Task
Status

Postponed: needs info

Version

11.0 πŸ”₯

Component
Layout builderΒ  β†’

Last updated 2 days ago

Created by

πŸ‡·πŸ‡΄Romania amateescu

Live updates comments and jobs are added and updated live.
  • Blocks-Layouts

    Blocks and Layouts Initiative. See the #2811175 Add layouts to Drupal issue.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024