Contrib.social

LayoutEntityHelperTrait::isLayoutCompatibleEntity() should check whether the entity type has a view builder class

Open on Drupal.org →
Created on 7 May 2019, about 6 years ago
Updated 30 January 2024, over 1 year ago

Problem/Motivation

\Drupal\layout_builder\LayoutEntityHelperTrait::isLayoutCompatibleEntity() is invoked on every entity presave by \Drupal\layout_builder\InlineBlockEntityOperations::handlePreSave(), and the code for checking layout_builder compatibility is quite expensive and involves creating contexts and whatnot.

Proposed resolution

Entity types that don't have a view builder handler (most config entities) can never be managed by Layout Builder, so we should add check for that.

Remaining tasks

Review.

User interface changes

Nope.

API changes

Nope.

Data model changes

Nope.

Release notes snippet

Nope.

📌 Task
Status

Postponed: needs info

Version

11.0 🔥

Component
Layout builder  →

Last updated 32 minutes ago

Created by

🇷🇴Romania amateescu

Live updates comments and jobs are added and updated live.
  • Blocks-Layouts

    Blocks and Layouts Initiative. See the #2811175 Add layouts to Drupal issue.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 1 year ago →
    🇺🇸United States smustgrave

    Wonder if anyone could provide additional information before this one is closed out?

  • Status changed to Closed: works as designed 23 days ago
  • Comment 23 days ago →
    🇳🇿New Zealand quietone

    A year has passed and there has been no interest in providing the information asked for 3 years ago in #15. Therefor, closing this issue per #15.

    If there is work to do here, then either re-open the issue or open a new issue and reference this one. If the choice is to use this issue then add a comment change make sure to change the issue status to 'Active'.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024