- Status changed to Needs review
over 1 year ago 10:12pm 25 January 2023 - Status changed to Needs work
over 1 year ago 4:29am 26 January 2023 - 🇺🇸United States smustgrave
Thank you for this! See this often with clients who aren’t great with layout builder.
Still seem to be some test failures however. Definitely keeping this on the radar
- Status changed to Needs review
about 1 year ago 2:58am 8 April 2023 - 🇺🇸United States smustgrave
@tim.plunkett added a condition so the sections do build in layout builder side.
Thoughts?
- Status changed to Needs work
about 1 year ago 3:15pm 8 April 2023 - 🇺🇸United States smustgrave
Thanks. Also seemed to cause some additional test failures that I'll look at.
- Status changed to Needs review
about 1 year ago 2:06am 9 April 2023 - 🇺🇸United States smustgrave
So this additional checks seems to be the best way to cover all scenarios.
When adding a section _layout_builder isn't there.
Tried _admin_route but that caused test failures also.
- Assigned to tim.plunkett
- 🇺🇸United States tim.plunkett Philadelphia
Fixing merge (using rebase) to allow me to review better
- 🇺🇸United States smustgrave
@tim.plunkett wonder if you had a chance to review?
- 🇺🇸United States tim.plunkett Philadelphia
I'll have to re-review, the change to checking for `layout_builder_tempstore` is tricky
- Status changed to Needs work
about 1 year ago 11:42pm 10 May 2023 - 🇺🇸United States smustgrave
Tried this out on a local project and I use drush search-api-index
But I get this error
> [error] Error while trying to render item entity:node/48:en with view mode full for search index tetra_tech: Call to a member function getOption() on null in Drupal\Core\Layout\LayoutDefault->build() (line 70 of /var/www/html/webroot/core/lib/Drupal/Core/Layout/LayoutDefault.php).
So seems all scenarios aren't caught.