The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇺🇸United States cboyden
The placeholder labels still cause an issue when trying to style the LB interface. Is the approach in this ticket still being considered, or are there other proposed solutions?
- 🇺🇸United States klu
Thanks for your work on this, @bnjmnm! The changes in your patch would be really helpful for us. I’ve taken a stab at re-rolling for 10.3.x based on patch 3 and the interdiff. It appears to work for me and is a significant improvement for doing our styling. I’m attaching the patch that I’m using, but I did not try to update the tests (my apologies; I’m newly coming back to Drupal development).
- 🇳🇿New Zealand danielveza Brisbane, AU
Hey @klu, could you please create a merge request from the patch that you've created against the 11.x branch?
There is some documentation here → about how to create merge requests for Drupal issues.
Thanks!
- 🇺🇸United States cboyden
I've created an issue fork from 11.x and ported the changes from patch #20. Still needs updated tests.