Contrib.social

Deprecated code in the contrib module page_manager

Open on Drupal.org ā†’
Created on 23 November 2023, about 1 year ago

Problem/Motivation

I used the "Upgrade Status" module to scan for deprecated code in the WxT distribution and I found this issue in the contrib module page_manager:

------ -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Line page_manager/page_manager_ui/src/Form/PageGeneralForm.php ------ -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

182 Relying on entity queries to check access by default is deprecated in drupal:9.2.0 and an error will be thrown from drupal:10.0.0. Call \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with TRUE or FALSE to specify whether access should be checked.
šŸ’” See https://www.drupal.org/node/3201242
------ -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Steps to reproduce

See scan results above

Proposed resolution

There's already a patch for this here: https://www.drupal.org/project/page_manager/issues/3397945 šŸ› Relying on entity queries to check access by default RTBC , I tested the patch and works ok, no warnings after I applied the patch (and scanned the project again after applying the patch):

Remaining tasks

Create a patch for the WxT composer.json file to include this patch for now, or at least until they release a new version with this fix.

User interface changes

API changes

Data model changes

šŸ› Bug report
Status

Fixed

Version

5.0

Component

Code

Created by

šŸ‡ØšŸ‡¦Canada danrod Ottawa

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024