- Issue created by @smulvih2
- 🇨🇦Canada RobinGalipeau
Hi Stephen,
So is this what Liam can commit... Based on email thread?
/** * Implements hook_preprocess_page_title(). */ function MY_THEME_preprocess_page_title(&$variables) { $variables['gc_thickline'] = TRUE; }
- 🇨🇦Canada smulvih2 Canada 🍁
No, this is currently how to set the gc-thickline if not using lead title. To make gc-thickline the default used, he will need to change the page-title.html.twig file in wxt_bootstrap, plus review wxt_bootstrap.theme for any gc-thickline logic.
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
The attached patch to
wxt_bootstrap
makesgc-thickline
the default by adjusting the template.gc_thickline
can be set to false to avoid this if needed. - 🇨🇦Canada joseph.olstad
or, just upgrade to GCWeb 14.5.0 , no change to twig is needed.
- 🇨🇦Canada joseph.olstad
See this commit
https://git.drupalcode.org/project/wxt_library/-/commit/e7d754930eaecb91...
It'll be in the next release.
- Status changed to Needs review
9 months ago 7:09pm 27 March 2024 - 🇨🇦Canada joseph.olstad
this patch will conflict with the GCWeb 14.5.0 upgrade
- 🇨🇦Canada smulvih2 Canada 🍁
@joseph you are correct, the GCWeb PR attached show that they have remoed h1.gc-thickline and now the style applies to the plain H1.
- Status changed to Fixed
9 months ago 5:54pm 1 April 2024 - 🇨🇦Canada joseph.olstad
I'm not 100% sure however I did back off the thickline from our css when using GCWeb 14.5.0 , it is not needed.
This change may actually cause a regression and result in a double underline when used in combination with GCWeb 14.5.0.
Automatically closed - issue fixed for 2 weeks with no activity.