Upgrade core to 10.3.x

Found an issue with CKEditor5. When creating/editing a page, if you switch to the Rich Text (CKEditor5) text format, you get an error in the console and the editor fails to initialize:

TypeError: delegated_uifrom_dll_reference_CKEditor5.Model is not a constructor

Drupal 10.3.x upgraded CKE5 from 41.2.0 to 41.3.1, which introduced a breaking change. CKEditor has renamed an export in ckeditor5/src/ui from Model to ViewModel. This was causing a JS error in the console, and CKE5 was completely not usable. I pushed a commit to the 10.3.x branch to fix this - https://github.com/drupalwxt/wxt/commit/60bf7ea0d903a7f9f2776a8bb747c7158d880eac

I have tested both the alert and panel CKE5 widgets and they work as expected now, and CKE5 is usable again.

Great, is ck4 still usable?

Yes CKE4 is still usable, no breaking changes for CKE4.

Updated a drupal/core patch after getting an error when running a migration:

Optional parameter $account_switcher declared before required parameter $entity_type_bundle_info is implicitly treated as a required parameter in /var/www/html/dv13.openplus.ca/html/core/modules/migrate/src/Plugin/migrate/destination/EntityContentBase.php on line 142

The latest core MR/patch on that ticket resolves the issue. Change to patch here - https://github.com/drupalwxt/wxt/commit/7c77b699b51dfb20a48109621fb65c4f21f3e6dd

Found an issue - the CKE5 text formats form throws errors when saved (even with no changes).

'footnotes_collapse' is not a supported key.
'footnotes_html' is not a supported key.
'footnotes_css' is not a supported key.
'type' is not a supported key.
'auto' is not a supported key.
'block' is not a supported key.
'exclude_above' is not a supported key.
'url_prefix' is not a supported key.
'responsive' is not a supported key.
'replace_classes' is not a supported key.
'replace_all_classes' is not a supported key.
'classes' is not a supported key.
'whitelist_classes' is not a supported key.
'add_datatable_attribute' is not a supported key.
'datatable_options' is not a supported key.

1 error has been found: Manually editable HTML tags

If I update drupal/footnotes from 3.1.0 to 4.0.0-beat5 it fixes the first three lines, but breaks the icon bar. Will have to look at each module providing these settings. Looks like these keys need to be added to the associated *.schema.yml files.

Fixed 7 issues from the list above by adding the required schema.yml file to wxt_ext_editor for the filter plugin - https://github.com/drupalwxt/wxt/commit/b805b5ea2e688dd0124fa149dba3121636cc7061

Fixed the remaining key errors by updating footnotes, toc_filter, and url_embed modules - https://github.com/drupalwxt/wxt/commit/bf65e073951d4c683301407df0c2a952af983250

Fixed the remaining issues with the CKE5 text formats - https://github.com/drupalwxt/wxt/commit/de00a206f1b7266917844d7fb6f8dd98977b5867

I'm now able to edit the text formats and save them without error.

Very nice, so how many ck5 text formats are there? I see you fixed it for rich text ck5, what about full html ck5? does that need it also?

This one likely also needs the fix:
https://github.com/drupalwxt/wxt/blob/5.3.x/modules/custom/wxt_ext/wxt_e...

No that other CKE5 text format doesn't use footnotes, nor does it have the <drupal-entity> config for allow list.

A new dev release 5.3.x → has been created for the Drupal core 10.3.x upgrade. I have been testing this upgrade in a large project for the last month and have fixed all issues identified.

Setting this to RTBC until @sylus does an official release.

I think 5.3.x is ready for 5.3.0 to be tagged?

A client has been using 5.3.x in production for a few weeks now and the upgrade process was fairly straight forward!

Thanks so much @joseph.olstad and @smulvih2 for doing all the work pushed this out tonight :)

Automatically closed - issue fixed for 2 weeks with no activity.