Contrib.social

[D10] deprecated styles in the file themes/contrib/wxt_bootstrap/css/style.css

Open on Drupal.org →
Created on 24 November 2023, 7 months ago
Updated 4 December 2023, 7 months ago

Problem/Motivation

I am using the module "Upgrade Status" to scan a few projects and I found some deprecated styling in the file themes/contrib/wxt_bootstrap/css/style.css:

According to this information → , the selector #drupal-off-canvas is deprecated and should be replaced with the selector #drupal-off-canvas-wrapper in Drupal 10

#drupal-off-canvas-wrapper {
}

Steps to reproduce

- Install module "Upgrade Status" and run a scan against the project wxt_bootstrap

Proposed resolution

- Changes in the /sass/modules/_wxt.scss and /css/style.css to replace the deprecated CSS selector.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

5.0

Component

WxT Bootstrap

Created by

🇨🇦Canada danrod

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @danrod
  • Status changed to Needs review 7 months ago
  • Comment 7 months ago →
    🇨🇦Canada danrod

    Attached a patch to fix this, after applying it, I ran the "Upgrade Status" module against the wxt_bootstrap project again and I don't see the warning any more:

    I can also see that the styling for the CSS selector #drupal-off-canvas-wrapper is correctly applied now:

  • Status changed to Needs work 7 months ago
  • Comment 7 months ago →
    🇨🇦Canada sylus

    Nice find :)

    I don't see a patch attached though? Maybe was missed?

    Thanks for finding this though!

  • Status changed to Needs review 7 months ago
  • Comment 7 months ago →
    🇨🇦Canada danrod

    Oh sorry for this, must have missed it somewhere, here's the patch.

  • Status changed to Fixed 7 months ago
  • Comment 7 months ago →
    🇨🇦Canada sylus

    Committed and attributed :)

    Thanks so much!

  • Comment 6 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024