Add modal to content with CKEditor

Patches attached implement the new custom block type Modal, as well as associated linkit plugins and filter to allow embedding within CKEditor. Tested on CKE4 and CKE5, works the same across both. Also tested multiple modals on a single page and works without issue. New Modal block type is fully translatable, and the text filter correctly returns the correct translation for block content.

The nice part about this approach is the modal is only added to the page when a linkit link points to it. Once the link is removed so too is the modal markup. Also allows for reusable modals that can be embedded on multiple pages and managed in one spot.

Thanks @smulvih2 I had an issue when applying the patch wxt-bootstrap-modal-block-3391443-2.patch , perhaps something needs to be done before applying the patch?

@danrod

the patch is for wxt 5.0.x

are you applying it to wxt 4.x?

also, there's two patches, which one did you apply first?

@danrod, I made the patches against the 5.0.0-rc2 branch, but was also able to apply the patches to a project using the 5.0.x-dev branch as well. Let me know what version of WxT you are trying to apply these patches against and hopefully we can figure out what the issue is.

Thanks @smulvih2 I was applying the patches against the 4.x branch, I'm trying to update WXT to 5.0.0 in order to apply the patches but I am having a bunch of issues, I'll post these in another issue.

Thanks @joseph.olstad @smulvih2 on your help on this, I was able to apply the patch, I see the new Custom block type "Modal", I created a new block of that type, tried to use it in the editor, but I don't know how to add the new "block", should I search by Modal ID?

@danrod appreciate your help reviewing this! To place the modal link, use the linkit plugin and search against the block title. You should now be able to see modal blocks as suggestions.

Hi @smulvih2 would you mind also adding this to our overview page in docs similar to other improvements?

Thanks for the great work!

@sylus added this feature to the existing PR from earlier today - https://github.com/drupalwxt/drupalwxt.github.io/pull/3

This looks great!

Committed and attributed!

Automatically closed - issue fixed for 2 weeks with no activity.