- Issue created by @Liam Morland
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 5:25pm 19 January 2024 - 🇨🇦Canada sylus
This looks awesome!
Thanks @Liam for the improvement!
Committed and attributed!
Will add this functionality to the docsite.
-
Liam Morland →
authored 842778c1 on 5.2.x
Issue #3415924 by Liam Morland: Allow setting GC Adobe Analytics metatag...
-
Liam Morland →
authored 842778c1 on 5.2.x
- Status changed to Fixed
about 1 year ago 1:01am 25 January 2024 Automatically closed - issue fixed for 2 weeks with no activity.
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
Following client testing, it has been discovered that additional spaces are needed.
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
It appears to be necessary to have exactly four levels. This patch pads empty levels with "N/A".
- 🇨🇦Canada jwylarsen
I don't see a meta element added to the page source when I provide a value in these fields. Am I doing something wrong?
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
You need to visit
admin/config/search/metatag
, edit the tag type, scroll down to "Adobe Analytics", and put a token in the field. - 🇨🇦Canada jwylarsen
Does it have to be a token? I tried putting in a literal string and don't see it in the head.
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
Check the code for details. I think it has to be a token for a field such as
[node:field_fieldname]
. - Status changed to Needs review
23 days ago 4:27pm 26 March 2025 - 🇨🇦Canada joel_osc
Hope I don't offend anyone for re-opening this... it seems there is a follow-up patch that is needed.
- 🇨🇦Canada smulvih2 Canada 🍁
Hmmm, the patch in #8 seems to be in the 5.4.x branch - https://github.com/drupalwxt/wxt/blob/63cde06e8c52aa001284cb4ff8bf2e5c7a3f4a56/modules/custom/wxt_ext/wxt_ext_metatag/src/Plugin/metatag/Tag/AdobeAnalyticsAttributeBase.php#L109
Which branch are you seeing this issue in?
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
I noted it missing from 5.2.x and since I didn't see a linked commit, I supposed it had not been committed. I see it was added in commit ac03fc27. I wonder why it doesn't appear here. Anyway, it's fine. This issue can go back to "Closed (fixed)".
Automatically closed - issue fixed for 2 weeks with no activity.