- Issue created by @danrod
- Status changed to Needs review
10 months ago 6:58pm 19 January 2024 - 🇨🇦Canada joseph.olstad
I also fixed this, however, in the upstream issue.
See my interdiff upstream
#2938129-42: PageTitle block is non-functional when not handled directly by \Drupal\block\Plugin\DisplayVariant\BlockPageVariant →
https://www.drupal.org/files/issues/2024-01-21/2938129-interdiff_41_to_4... →
and new patch
https://www.drupal.org/files/issues/2024-01-21/drupal-PageTitle_block-29... → - 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
We were having this problem as well. Switching from patch 41 to 42 fixed it for us.
- 🇨🇦Canada joseph.olstad
Thanks @Liam Morland for rolling the wxt update to use the new patch 42
-
Liam Morland →
authored d7f80ba8 on 5.2.x
Issue #3415945 by Liam Morland: [WxT 5.2] Deprecated function:...
-
Liam Morland →
authored d7f80ba8 on 5.2.x
- Status changed to Fixed
10 months ago 12:42am 25 January 2024 - 🇨🇦Canada sylus
Thanks for this everyone!
Committed and attributed the patch to core!
- 🇨🇦Canada kevin.bruner
What's the most appropriate way to include this patch in my drupal sites?
I haven't done a lot of patch inclusions in my composer.json.
I'm using the wxt-site example with this line: "drupalwxt/wxt": "5.2.x"
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
- 🇨🇦Canada kevin.bruner
I don't think my issue so much is that I don't know how to actually insert it into my composer.json, it's that I'm pulling this upstream by using the site-wxt example rather than using a custom composer.json of the wxt composer.json. It's a conceptual issue for including this patch in my implementation that I struggle with rather than the concept of patching entirely.
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
You can add the patch to your top-level Composer file.
- 🇨🇦Canada kevin.bruner
I've done so, I believe. And my site builds correctly, however, the issue persists. This is why I'm thinking I must have done something wrong
"patches": {
"drupalwxt/wxt" :{
"fix for title issue":
" https://www.drupal.org/files/issues/2024-01-22/wxt-update_patch_2938129-... → "
}
},This is from a fresh build with a re-import and update of the database on a dev server.
- 🇨🇦Canada joseph.olstad
Kevin, you'll want to modify your directive, it's a core patch
Example:
"patches": { "drupal/core" :{ "2938129 - <-- Issue number is helpful for later - Drupal core page title block patch.": "https://www.drupal.org/files/issues/2024-01-21/drupal-PageTitle_block-2938129-42.patch" } },
In this case it's pretty simple, it's a patch for core, for patch ignores it gets more complicated as you have to do wrapping and pay a bit more attention.
You got mixed up because Liam is making a patch to fix wxt build, not for core, it's a bit tricky to explain why it doesn't help you.
Try the suggested patch mentioned , patch 42 of 2938129 for core.
- 🇨🇦Canada kevin.bruner
Thank you! This makes sense to me conceptually and I thank you for taking the time to explain it. I hope this thread can illuminate for anyone else like me.
- 🇨🇦Canada joseph.olstad
@kevin.bruner
Cool, thanks for the followup! Anything is possible with composer if you spend enough time working with it. With that said, you've got a working solution and that is most important! - 🇨🇦Canada joseph.olstad
ya since you're on the drupalwxt/wxt 5.x-2.x release already you should be able to just run an update to update your build.
This gets everything:
composer up -W
Or if you only want to update drupalwxt/wxt components and maybe say, core, you could try this:
composer up drupalwxt/wxt drupal/core symfony/* twig/* drupal/wxt_library drupal/wxt_bootstrap
if there's some dependency warning, just add it to the parameter list.
Sometimes you may need to unlock something in your composer.json if it's in conflict. Composer does a good job of illustrating the conflicts. It takes a bit of practice to see how to read and learn how to react.
Automatically closed - issue fixed for 2 weeks with no activity.