- πΊπΈUnited States smustgrave
Since there hasn't been a follow up going to close out for now. If still a valid task please reopen.
Thanks all
Let's add a new library definition:
drupal.node:
version: VERSION
css:
css/node.module.css: {}
... this looks reasonable, but in fact this is broken. You need to specify a category:
drupal.node:
version: VERSION
css:
layout:
css/node.module.css: {}
This is far from being obvious.
Add some validation code in LibraryParser.php
to ensure the "category" is right.
In case you use a path as category, throw an exception like:
You have to key the css files in the "$module.library.yml" file by category (css/node.module.css seems is a filename, allowed categories are ...)
In case someone actually uses a category, throw an exception like:
You use an invalid category "invalid_cateogry" in "module.libraries.yml". Allowed categories are ...
An example for such a library.yml file would be:
drupal.node:
version: VERSION
css:
invalid_category:
css/node.module.css: {}
Fix tests that are not using categories.
Closed: outdated
9.5
Enhances developer experience.
The patch will have to be re-rolled with new suggestions/changes described in the comments in the issue.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Since there hasn't been a follow up going to close out for now. If still a valid task please reopen.
Thanks all