Please let me know if I need to do anything else.
I've noticed that some projects created in March have already been approved.
Yes, @nadja_stu you are right, although it is not mandatory, I think it is a good practice, to access any of the services provided by Drupal via the service container to ensure the decoupled nature of these systems is respected.
Services and dependency injection in Drupal →
1. FILE = src/Form/BrevoContactMappingForm.php
public function fieldContent() {
$options = [];
$listUsersFields = $this->entityFieldManager->getFieldDefinitions('user', 'user');
foreach ($listUsersFields as $field) {
$fieldName = $field->getName();
if (isset($fieldName)) {
$selected_value = $fieldName;
$entityManager = \Drupal::service('entity_field.manager');
$definitions = $entityManager->getFieldDefinitions('user', 'user');
Use $this->entityFieldManager property instead of \Drupal::service
1. FILE = src/Routing/APIRouteBuilder.php
/**
* EndpointRouteBuilder constructor.
*/
public function __construct(LoggerChannelFactory $loggerFactory, APIManager $apiManager) {
The documentation comment for constructors is not mandatory anymore, If it is given, the description must be “Constructs a new [class name] object”, where [class name] includes the class namespace.
2. FILE = src/Controller/EndpointController.php
/**
* EndpointController constructor.
*/
public function __construct(EndpointManager $endpointManager) {
The documentation comment for constructors is not mandatory anymore, If it is given, the description must be “Constructs a new [class name] object”, where [class name] includes the class namespace.
Hi @nadja_stu
1. FILE = src/Hook/InactiveUserManagementHooks.php
public function cron(): void {
/** @var \Drupal\Core\State\StateInterface $drupalState */
$state = \Drupal::service('state');
$emailState = $state->get(NotificationSettings::NOTIFICATION_SETTINGS_PREFIX . '_enabled');
if ($emailState) {
/** @var \Drupal\inactive_user_management\Notification\InactiveUserNotification $userNotification */
$userNotification = \Drupal::service('inactive_user_notification');
$userNotification->sendNotificationToInactiveUsers();
}
// Manually process the queue.
/** @var \Drupal\Core\Queue\QueueFactory $queueFactory */
$queueFactory = \Drupal::service('queue');
$queue = $queueFactory->get('inactive_user_notification');
$queueWorkerManager = \Drupal::service('plugin.manager.queue_worker');
$queueWorker = $queueWorkerManager->createInstance('inactive_user_notification');
while ($item = $queue->claimItem()) {
$queueWorker->processItem($item->data);
$queue->deleteItem($item);
}
}
You should use dependency injection instead of \Drupal calls in classes, implementing ContainerInjectionInterface.
1. FILE: src/EventSubscriber/TaxonomyOverviewFormAlterSubscriber.php
/**
* Construct the TaxonomyOverviewFormAlterSubscriber.
*
* @param \Drupal\Core\Database\Connection $connection
* The database connection which will be used to store the flood event
* information.
*/
public function __construct(Connection $connection) {
$this->connection = $connection;
}
The documentation comment for constructors is not mandatory anymore, If it is given, the description must be “Constructs a new [class name] object”, where [class name] includes the class namespace.
Hello @vishal.kadam,
I have already fix the problems.
Thank you very much for your review.
Fix the following phpcs warnings and errors:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,yml kiosk_nav/
FILE: /var/www/html/web/modules/contrib/kiosk_nav/css/kiosk-nav-query.css
-------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------
1 | ERROR | [x] Additional whitespace found at start of file
-------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------
FILE: /var/www/html/web/modules/contrib/kiosk_nav/kiosk_nav.info.yml
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-------------------------------------------------------------------------------------------------------------
Hello @nadja_stu,
I have already fix the problems with coding standards.
Thank you very much for your review.
alexismmd → created an issue.
alexismmd → made their first commit to this issue’s fork.
aarnau → credited alexismmd → .
alexismmd → made their first commit to this issue’s fork.
+1
alexismmd → created an issue.
alexismmd → changed the visibility of the branch 2118743-twig-debug-output-updated-11-x to hidden.
alexismmd → made their first commit to this issue’s fork.
alexismmd → changed the visibility of the branch 3047392-site-uuid-in-from-10 to active.
Hi @vasike
I don't know why but now MR doesn't apply in 10.1.7
alexismmd → changed the visibility of the branch 3047392-site-uuid-in-from-10 to hidden.
@alexpott, the update of MR 4133 was need it. I see you already have done, then yes I going to hidden MR 5690, sorry about that. Thanks!
alexismmd → changed the visibility of the branch 3047392-site-uuid-in-from-10 to hidden.
alexismmd → changed the visibility of the branch 3047392-site-uuid-in-from-10 to active.
alexismmd → changed the visibility of the branch 3047392-site-uuid-in-from-10 to active.
alexismmd → changed the visibility of the branch 3047392-site-uuid-in-from-10 to hidden.
alexismmd → made their first commit to this issue’s fork.
alexismmd → made their first commit to this issue’s fork.
alexismmd → made their first commit to this issue’s fork.
alexismmd → made their first commit to this issue’s fork.
alexismmd → made their first commit to this issue’s fork.