Account created on 7 March 2008, almost 17 years ago
#

Merge Requests

Recent comments

πŸ‡ΊπŸ‡ΈUnited States omerida

Are there any details on how the patch in #254 and earlier break the suggestions functionality? I applied it cleanly and did a diff between the HTML source pre- and post- patch. The only difference highlighted was that the patch removes the spaces between the dot and filenames in one case. I re-rolled the patch to fix that and then the only difference with the patch is that views suggestions show up in the HTML comments.

Line 1737 of the patch is missng a space:

$suggestion = 'β–ͺ️ ' . strtr($suggestion, '_', '-') . $extension;

πŸ‡ΊπŸ‡ΈUnited States omerida

I dug into why we couldn't use a higher path count too and discovered a couple of issues. I have a merge and patch request over in #3478842

πŸ‡ΊπŸ‡ΈUnited States omerida

Attached is a patch file with the proposed changes:

1. Adds an internal $init_paths array to tome_static/src/Commands/StaticCommand.php to track the initial paths requested for export. When we get invoked paths in exportPaths(), filter out any invoke_paths that are already in the initial paths.

2. In tome_static/src/Commands/StaticExportPathCommand.php, run $invoke_paths through array_unique() to remove duplicates.

3. In tome_static/src/RequestPreparer.php, I stepped through runs with path count > 1 and found that the menuActiveTrail has to be cleared, not reset, to ensure menu blocks are correctly generated for each path.

Production build 0.71.5 2024