Netherlands
Account created on 5 September 2009, about 15 years ago
#

Merge Requests

Recent comments

πŸ‡³πŸ‡±Netherlands renΓ© bakx Netherlands

This is a much needed feature and the patched got the job done!

It bit us in the back on a production env. Wondering why we where still seeing stale cache for objects set to never expire and no cache-tags to help them being evicted in other way.

And yes you are right, it's wrong and somewhat foolish to rely on cache clear to solve this problem, yet is worked perfectly till we moved that project to use redis for cache.

So yeah, please merge this and cut a new release :D

πŸ‡³πŸ‡±Netherlands renΓ© bakx Netherlands

Thanks for your rapid action :)

We are going to move forward in production with this contextual system, so if we find more issues I will try to fix them as well.
Like I said in the tweet (for those who read along with X), contextual media is the missing link in Drupal media management. Upload image once, use multiple versions with their own crop.

πŸ‡³πŸ‡±Netherlands renΓ© bakx Netherlands

While working on the MR I noticed that a single responsive image style can have multiple images with a extra sizes rule, so I adjusted my original version to handle those as well.

πŸ‡³πŸ‡±Netherlands renΓ© bakx Netherlands

Added a simple PHPStorm DIFF/History patch.

πŸ‡³πŸ‡±Netherlands renΓ© bakx Netherlands

The templates as defined in https://www.drupal.org/project/entity_reference_layout/issues/3380291 πŸ“Œ Drupal 10 Masterpatch to keep ERL alive with RTBC'd issue patches Fixed did not land in the git repo.

the content of those files are not that complicated, i've distilled them from the zipfile in https://www.drupal.org/project/entity_reference_layout/issues/3380291#co... πŸ“Œ Drupal 10 Masterpatch to keep ERL alive with RTBC'd issue patches Fixed

entity-reference-layout-widget.html.twig

{{ fieldset }}

entity-reference-layout-radio.html.twig

{{ layout_item }}

entity-reference-layout.html.twig

{{ content }}
πŸ‡³πŸ‡±Netherlands renΓ© bakx Netherlands

The patch in #16 is incomplete, there is another PHP8 construct in Generator.php (src/Manager/Generator.php) as well.

 public function getDefaultVariant(): ?string {
    return $this->getDefaultSitemap()?->id();
  }
πŸ‡³πŸ‡±Netherlands renΓ© bakx Netherlands

Fixed in next release

πŸ‡³πŸ‡±Netherlands renΓ© bakx Netherlands

Added some more context to this issue.

πŸ‡³πŸ‡±Netherlands renΓ© bakx Netherlands

Adding the backwards compatible as suggested in #14 actually breaks it again.

'oneOf' => [
      ['type' => 'array'],
      ['type' => 'object'],
],

The check on array fails in the external library mentioned in #6

JsonSchema\Exception\InvalidArgumentException: Array is an invalid type for Array in JsonSchema\Constraints\TypeConstraint->validateType() 
πŸ‡³πŸ‡±Netherlands renΓ© bakx Netherlands

Closed MR, rolled the patch manually on the current default version and tagged the 8.0.0-beta2 release with the changes suggested by Project Update bot.

To answer @Anybody in #6 My maintainer plans are at this moment in time minimal. I currently have no Drupal 10 sites to work on but I'm fully open to MR's from other people. But my time is somewhat limited at this moment as well.

πŸ‡³πŸ‡±Netherlands renΓ© bakx Netherlands

Rene Bakx β†’ made their first commit to this issue’s fork.

Production build 0.71.5 2024