rework theme_filter_tips to use the new Attributes, and call theme('item_list) while we're at it

Created on 8 September 2012, over 12 years ago
Updated 13 May 2025, 4 days ago

theme_filter_tips currently does this janky thing to add it's own classes to both the containing div for each filter, and the LI tags for each tip.

Can we re-work this theme function to use the new Attributes as per
#1290694: Provide consistency for attributes and classes arrays provided by template_preprocess() β†’

And while we're at it, can we please call theme('item_list) instead of writing our own UL and LI tags in this theme function?

πŸ“Œ Task
Status

Postponed: needs info

Version

11.0 πŸ”₯

Component

theme system

Created by

πŸ‡ΊπŸ‡ΈUnited States jenlampton

Live updates comments and jobs are added and updated live.
  • stale-issue-cleanup

    To track issues in the developing policy for closing stale issues, [Policy, no patch] closing older issues

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Thank you for creating this issue to improve Drupal.

    We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

    Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

    Thanks!

  • πŸ‡ͺπŸ‡¨Ecuador jwilson3

    The current parent meta issue assigned in comment #28 seems irrelevant at this point, since the filter-tips.html.twig that ships with Drupal 11 has appropriate use of Attributes and provides no default classes anymore.

    #25 πŸ“Œ rework theme_filter_tips to use the new Attributes, and call theme('item_list) while we're at it Postponed: needs info :

    we want to remove as many theme functions templates as possible that just duplicate things like e.g. a list and use suggestions instead.

    This may be a valid point and relevant to this issue, but this seems extremely low-priority. The community has embraced Twig templates everywhere. Having this template isn't causing anyone issues. And is arguably more flexible allowing themers to completley swap out the simple nested list for a <table>, or a <details> or another component for improved readability of long filter tips.

    I suggest closing this, but defer to more active core contributors for consensus.

Production build 0.71.5 2024