🇬🇧United Kingdom @rattusrattus

Hi joseph.olstad. Thanks very much for all your work on this.

I've taken a quick look through the MR. From what I can see, the the inclusion of a ToC is not configurable? I.e. users can't choose whether the PDF includes a ToC?

Thanks both.

Thanks both!

Thanks joseph.olstad! This has been included in 1.0.1.

Thanks joseph.olstad. I'll look to create a new release before the end of the week.

Sounds like a great idea joseph.olstad. I'll try to find some time to implement this week.

Thanks joseph.olstad. I'm not sure we've seen this but I'll try and reproduce. Contributions, of course, very welcome!

Patch attached.

rattusrattus → created an issue.

Thanks for your prompt response! Would you accept a MR to defer the include?

https://stripe.com/docs/js/including

rattusrattus → created an issue.

I had ran into this when indexing a computed field with an unset provider, e.g.

$fields['computed_field'] = BaseFieldDefinition::create('string')
      ->setLabel(t('Example computed field'))
      ->setReadOnly(TRUE)
      ->setComputed(TRUE)
      ->setClass(ExampleComputedField::class)
      ->setDisplayConfigurable('form', FALSE)
      ->setDisplayConfigurable('view', TRUE)
      ->setProvider('example_computed_field'); // <---

I haven't stepped through the code but would make sense given the following in `\Drupal\search_api\Entity\Index::getDependencyData()`:

$type_dependencies[$type]['module'][] = $definition['provider'];

Using the reproduction repo above I can track the issue down to the adjustment being added to the shipping in the tax type plugin.

rattusrattus → created an issue.