🇬🇧United Kingdom @rattusrattus

Thanks Alberto!

Ran into the same issue with a link field on a content entity. Tested with 3.3.0.

Thought you might be interested in my learnings\development implementing proxies for PartyTown on client project to get around CORS issues..

I've been using API Proxy → along with the following PartyTown config:

      const proxies = [
        { base: 'https://bat.bing.com/', slug: 'bat-bing'},
        { base: 'https://connect.facebook.net/', slug: 'fb'},
      ];
      if (proxy = proxies.find(proxy => url.href.startsWith(proxy.base))) {
        const uri = url.href.slice(proxy.base.length);
        return new URL(`https://drupal-sandbox.lndo.site/api-proxy/${proxy.slug}?_api_proxy_uri=${uri}`);
      }
      return url;

While API Proxy is a great module, I actually think that it's a bit overkill for just getting around CORS and if we included a proxy endpoint in the PartyTown module then we could accept the bases, as above, on the config form and inject them into the config via drupalSettings.

https://www.drupal.org/project/partytown →

rattusrattus → created an issue.

Thanks abenhow! You may have noticed from the issue fork that I had found a way include PartyTown as a Composer package but I've also just seen your issue on the PartyTown Github and I think that's a much better idea.

I will keep you posted on the ownership.

rattusrattus → created an issue.

rattusrattus → created an issue.

Hi there. I would like to work on this project and have enough together for an initial commit (which you can see on the issue fork). As no repo has been initialised for this project yet, and if you're not planning on working on it soon, then it may be easier if you just made me a maintainer. Thanks!

rattusrattus → made their first commit to this issue’s fork.

On the Drupal CMS Release Candidate is Available page, When the anchor with text "2. Download Drupal CMS zip" is focused the text becomes invisible.

@fisherman90 definitely possible using the addon as this is what I've ended up reverting to.

Actually, the above not so relevant but this one is pretty much the same problem:
https://stackoverflow.com/questions/77044691/how-can-i-force-storybook-t...

I guess this (unanswered) issue is relevant: https://github.com/storybookjs/storybook/discussions/15873

Possible the OP was asking hot we get storybook to reload when we make change to SDC twig\css\JS - something I am also thinking about...

rattusrattus → made their first commit to this issue’s fork.

rattusrattus → created an issue.

Hi joseph.olstad. Thanks very much for all your work on this.

I've taken a quick look through the MR. From what I can see, the the inclusion of a ToC is not configurable? I.e. users can't choose whether the PDF includes a ToC?

Thanks both.

Thanks both!

Thanks joseph.olstad! This has been included in 1.0.1.

Thanks joseph.olstad. I'll look to create a new release before the end of the week.

Sounds like a great idea joseph.olstad. I'll try to find some time to implement this week.

Thanks joseph.olstad. I'm not sure we've seen this but I'll try and reproduce. Contributions, of course, very welcome!

Patch attached.

rattusrattus → created an issue.

Thanks for your prompt response! Would you accept a MR to defer the include?

https://stripe.com/docs/js/including

rattusrattus → created an issue.

I had ran into this when indexing a computed field with an unset provider, e.g.

$fields['computed_field'] = BaseFieldDefinition::create('string')
      ->setLabel(t('Example computed field'))
      ->setReadOnly(TRUE)
      ->setComputed(TRUE)
      ->setClass(ExampleComputedField::class)
      ->setDisplayConfigurable('form', FALSE)
      ->setDisplayConfigurable('view', TRUE)
      ->setProvider('example_computed_field'); // <---

I haven't stepped through the code but would make sense given the following in `\Drupal\search_api\Entity\Index::getDependencyData()`:

$type_dependencies[$type]['module'][] = $definition['provider'];

Using the reproduction repo above I can track the issue down to the adjustment being added to the shipping in the tax type plugin.

rattusrattus → created an issue.