Follow-up to #2489394: Refactor the Search module markup to be inline with our standards. →
The parent issue updated the search result markup (search-result.html.twig) in Classy to follow BEM standards:
+<h3{{ title_attributes.addClass('search-result__title') }}>
<a href="{{ url }}">{{ title }}</a>
</h3>
{{ title_suffix }}
<div class="search-result__snippet-info">
{% if snippet %}
<p{{ content_attributes.addClass('search-result__snippet') }}>{{ snippet }}</p>
{% endif %}
{% if info %}
<p class="search-result__info">{{ info }}</p>
{% endif %}
</div>
The class names were not great before, and even with the BEMmification could be improved and made less ambiguous.
Discuss some alternative class names to replace/partially replace these:
search-result__snippet-info
search-result__snippet
search-result__info
Discuss
Patch
Patch review
Visual regression tests
n/a
n/a
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Gauravvvv → made their first commit to this issue’s fork.
First item in the tasks is to discuss but don't see that. This could have some BC concerns that need to be considered.