Consolidate use of admin-page.html.twig and system-admin-index.html.twig

Open on Drupal.org →

Created on 16 November 2012, over 12 years ago

Updated 6 May 2025, 11 days ago

The output of these two functions is identical, let's please consolodate.

<div class="admin clearfix">
  {{ system_compact_link }}
  {% for class, content in container %}
    <div class="{{ class }} clearfix">
      {{ content }}
    </div>
  {% endfor %}
</div>

📌 Task

Status

Active

Version

11.0 🔥

Component

system.module

Created by

🇺🇸United States jenlampton

Live updates comments and jobs are added and updated live.

Twig

theme system cleanup

Template consolidation

Incomplete comments

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 11 days ago →
🇦🇺Australia mstrelan
Not sure what this is postponed on so I'm marking it as Active.

FWIW the IS suggests that the output of the two templates is the same, but it's not. As per #3 one template has "layout-column" classes and the other has "left" and "right" classes, that don't actually work.

Also pointing out that admin-page.html.twig is overridden in Claro, but system-admin-index.html is not, and it seems the main difference is the lack of a wrapping clearfix class.

I think we should deprecate system-admin-index.html and use admin-page.html.twig for the /admin/index route. This would also restore the two column layout that presumably once worked.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024