The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
over 1 year ago 1:19pm 15 March 2023 - Status changed to Needs work
over 1 year ago 1:55pm 15 March 2023 - 🇺🇸United States smustgrave
Happy to see there are tests in there.
The issue summary should be updated with what is being added, The "why" is there. Would recommend using default issue template.
If we are adding a new twig function or way to render it will need a change record.
=====
Just FYI to help get the message out there.
Starting March 2023, simple rerolls, rebases, or merges will no longer receive issue credit. Only rerolls that address a merge conflict will be credited, and the merge conflict that was resolved must be documented in the text of an issue comment.
Example
error: patch failed: core/modules/system/tests/modules/twig_theme_test/twig_theme_test.module:77
error: core/modules/system/tests/modules/twig_theme_test/twig_theme_test.module: patch does not applyTo receive credit for contributing to this issue, assist with other outstanding tasks or unaddressed feedback.
See the issue credit guidelines → for more information. - 🇦🇺Australia sime Canberra
Wow, this gets the award for the simplest patch I didn't know i needed. Very neat.