- 🇨🇦Canada Ambient.Impact Toronto
deferattribute plus this issue fork, because removing the attribute and removing the patch instantly fixed the JS aggregates.
On top of that, given that there are also other attributes that we may want to group by (e.g.
fetchpriorityas mentioned by #81) and that new attributes may come along later, I propose reworking this as a more generic approach:
Instead of hard-coding the attributes (i.e.
defer, etc.) we add a settings.php setting which is an array of attribute names that can be grouped, with the default being
['async', 'defer']- this will make it easy for sites to opt into aggregating with other attributes based on their needs and be more future proof.
- 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
Wow, those test failures make no sense at all 🙃
I did spot one problem in the current MR, but doubt that'll fix it.