Disabled and readonly form element attributes should be boolean HTML5 attributes

Adding patch file.

MR 4816 is pointing to correct branch. 11.x is the current development branch of core.

If you need a hard link for 10.1 it's fine to post that but would leave a comment that it's just for 10.1

As a bug will need a test case showing the issue.
Also issue summary appears incomplete with missing parts.

Uploading new file patch, since I set the boolean value to a string previously. This is needed for 10.1.x

Fixed the failing tests. Uploading the patch. Please review.

The attributes in the current form (disabled="disabled" / readonly="readonly") seems to be valid in HTML5, see: https://html.spec.whatwg.org/multipage/common-microsyntaxes.html#boolean... .

They are boolean attributes and according to the specs:

2.3.2 Boolean attributes

A number of attributes are boolean attributes. The presence of a boolean attribute on an element represents the true value, and the absence of the attribute represents the false value.

If the attribute is present, its value must either be the empty string or a value that is an ASCII case-insensitive match for the attribute's canonical name, with no leading or trailing whitespace.

So this does not looks like a bug.

The patch #7 will change the output of such an attribute from:
<input disabled="disabled">
to:
<input disabled="">

If I read the specs correctly, both seems to be valid in HTML5 and looks pretty equivalent for me.

If we can achieve to have just: <input disabled> , then it can be a bit cleaner, but not sure if this can be achieved easily. Other option is to close this as Works as designed. Thanks!

@Aditi Saraf thank you for the interest in this but this was tagged for tests and issue summary update. When moving to review please read the comments and tags to make sure it's actually ready for review

@smustgrave thanks for your valuable suggestion . I will look into this .

Hi @smustgrave i have updated issue summary . and applied patch and interdiff #10 .

Thanks.

The patches #9 and #10 are not working and are wrong. They are setting the disabled attribute to FALSE, which is wrong and not valid HTML5. I am hiding these patches and moving back to NW.

My concerns from #8 are still valid, so please do not upload new patches which are only changing the string attribute values to boolean.

Rebased and fixed failing tests.

If we can achieve to have just: <input disabled> , then it can be a bit cleaner, but not sure if this can be achieved easily. Other option is to close this as Works as designed. Thanks!

Maybe something changed in core but I tested this and boolean attributes are displayed like you suggest.