Use element for 'mark' theme hook

Current theme function

Located in includes/theme.inc:

function theme_mark($variables) { $type = $variables['type']; global $user; if ($user->uid) { if ($type == MARK_NEW) { return ' ' . t('new') . ''; } elseif ($type == MARK_UPDATED) { return ' ' . t('updated') . ''; } } }

Potential Changes

The tag should be changed to .

The class should be removed. It's superflous. The element speaks for itself and context can be derived from the wrapper.

The core/theme CSS needs to adjusted where targeting .marker.  element has a yellow background and black foreground by default so we can remove the core styling from system.theme.css and style it however in the core themes, if at all.

The code itself could be cleaned up and simplified. Maybe it could take the string as an argument instead of dealing with constants. I say this because there are other places where it could be used easier if that were the case, such as comment.tpl.php:

<?php if ($new): ?>
    <span class="new"><?php print $new ?></span>
  <?php endif; ?>

When to Use the MARK Element

Showing search results

Highlight text in a quotation

Indicate new items in a list

Show the current date in a calendar

Highlighting an error

References

Related Issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment almost 2 years ago →

🇫🇷France andypost

+++ b/core/modules/history/src/Plugin/views/field/HistoryUserTimestamp.php
@@ -100,8 +100,15 @@ public function render(ResultRow $values) {
+        '#access' => ($mark == MARK_NEW || $mark == MARK_UPDATED),

+++ b/core/modules/system/templates/mark.html.twig
@@ -13,10 +13,10 @@
+{% if status is constant('MARK_NEW') %}
...
+{% elseif status is constant('MARK_UPDATED') %}
...
+{% elseif status is constant('MARK_READ') %}

+++ b/core/themes/classy/templates/content/mark.html.twig
@@ -13,8 +13,10 @@
   {% if status is constant('MARK_NEW') %}
...
   {% elseif status is constant('MARK_UPDATED') %}
...
+  {% elseif status is constant('MARK_READ') %}

+++ b/core/themes/stable/templates/content/mark.html.twig
@@ -16,5 +16,7 @@
   {% elseif status is constant('MARK_UPDATED') %}
...
+  {% elseif status is constant('MARK_READ') %}

Let's replace constants as well here

Comment almost 2 years ago →
🇬🇧United Kingdom catch
I'm still not convinced that this is applicable at all, see for example https://developer.mozilla.org/en-US/docs/Web/HTML/Element/mark
Comment almost 2 years ago →
🇬🇧United Kingdom catch