Remove default #size attribute from core

Open on Drupal.org →

Created on 11 February 2014, almost 11 years ago

Updated 18 April 2023, over 1 year ago

Background: #2002336-86: Introduce a CSS class to hide borders of fieldset elements →

Problem

An input element with a 'size' attribute value does not respect a max-width applied via CSS, when the input element appears in a fieldset.
http://stackoverflow.com/a/18039139/811306

For some reason the size attribute over-rode the css widths.
http://stackoverflow.com/a/1480592/811306

HTML controls the semantic meaning of the elements. CSS controls the layout/style of the page. Use CSS when you are controlling your layout.

In short, never use size=""

Proof

→ http://jsfiddle.net/sun/6gWA5/19/

Proposed solution

Remove the default value for #size from all form input elements throughout core.

pre-patch field sizes

Click the following images to view full-size.

Demonstrations of post-patch field sizes

📌 Task

Status

Needs work

Version

10.1 ✨

Component

Last updated about 20 hours ago

Maintained by
🇺🇸United States @effulgentsia
🇩🇪Germany @Fabianx
🇨🇦Canada @joelpittet
🇫🇮Finland @lauriii

Created by

🇩🇪Germany sun Karlsruhe

Live updates comments and jobs are added and updated live.

DrupalNorth2016

html5
Implements and supports the use of HTML5.

Bartik

Seven

Usability
Makes Drupal easier to use. Preferred over UX, D7UX, etc.

DevDaysMilan

Vienna2017

Needs subsystem maintainer review
It is used to alert the maintainer(s) of a particular core subsystem that an issue significantly impacts their subsystem, and their signoff is needed (see the governance policy draft for more information). Also, if you use this tag, make sure the issue component is set to the correct subsystem. If an issue significantly impacts more than one subsystem, use needs framework manager review instead.

Needs issue summary update
Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Incomplete comments

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment almost 2 years ago →
needs-review-queue-bot
The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
Comment over 1 year ago →
🇮🇳India nikhil_110
Attached patch against Drupal 10.1.x
Comment over 1 year ago →
🇮🇳India nikhil_110
Fixed CC issue
Status changed to Needs review over 1 year ago10:17am 18 April 2023
Comment over 1 year ago →
🇮🇳India rassoni Bangalore
Status changed to Needs work over 1 year ago3:08pm 18 April 2023
Comment over 1 year ago →
🇺🇸United States smustgrave
Was previous tagged for issue summary appears that still needs to happen also.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024