Images not proxied when file_public_path does not match web root

Open on Drupal.org →

Created on 8 June 2023, almost 2 years ago

Problem/Motivation

In some scenarios, proxy images are not served.

We have observed this in a Docker-based local development environment where the files directory is on a separate volume.

So the full path as the webserver sees it is /var/www/app-files/sites/default/files

In \Drupal\stage_file_proxy\EventSubscriber\ProxySubscriber::checkFileOrigin, the value returned from $this->manager->filePublicPath() is the absolute server path.

This means that the function returns early, because the file directory is not included in the request path.

Steps to reproduce

Set up a Docker environment with the files directory served from a separate volume
Set up stage file proxy
Load a page with images from production

Proposed resolution

tbc - perhaps change \Drupal\stage_file_proxy\FetchManager::filePublicPath so that

Remaining tasks

User interface changes

n/a

API changes

n/a

Data model changes

n/a

🐛 Bug report

Status

Active

Version

2.0

Component

Code

Created by

🇬🇧United Kingdom malcomio

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!81Images not proxied when file_public_path does not match web root
Closed
🇫🇷France Julien Tekrane
updated 4 months ago
!38Images not proxied when file_public_path does not match web root
Closed
🇬🇧United Kingdom malcomio
updated 5 months ago
!61Images not proxied when file_public_path does not match web root
Closed
🇬🇧United Kingdom malcomio
updated 5 months ago
!80Images not proxied when file_public_path does not match web root
Closed
🇫🇷France Julien Tekrane
updated 8 months ago

Comments & Activities

Issue created by @malcomio
Comment almost 2 years ago →
🇬🇧United Kingdom malcomio
Possibly related to ✨ Can this module handle multiple files directories on one site? Closed: outdated
Merge request !38Issue #3365703: Images not proxied when file_public_path does not match web root → (Closed) created by malcomio
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
1 pass, 2 fail
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
1 pass, 2 fail
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
1 pass, 2 fail
Pipeline finished with Canceled
over 1 year ago
Total: 269s
#18478
Pipeline finished with Canceled
over 1 year ago
Total: 131s
#18480
Pipeline finished with Failed
over 1 year ago
#18482
Pipeline finished with Failed
over 1 year ago
Total: 187s
#19679
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
1 pass, 2 fail
@malcomio opened merge request.
Pipeline finished with Failed
over 1 year ago
Total: 295s
#21026
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
1 pass, 2 fail
Pipeline finished with Failed
over 1 year ago
Total: 455s
#21031
Comment over 1 year ago →
🇬🇧United Kingdom malcomio
This issue also exists on the 2.1.x branch - updating the branch because 2.0.x is no longer supported.
Comment over 1 year ago →
System Message
malcomio → closed merge request !54
Comment over 1 year ago →
🇦🇺Australia nterbogt
I believe this is the same issue that I'm seeing.

URL that comes in is /sites/default/files/2022-05/Vivid.jpg

Proxy request is stage_file_proxy.ERROR: Stage File Proxy encountered an error when retrieving file https://my.host///2022-05/Vivid.jpg
Comment over 1 year ago →
🇩🇪Germany a.dmitriiev
I have also encountered with the same problem. In my case the file public path on remote instance (sites/remote_site/some_folder/files) was not the same as locally (sites/default/files). The origin_dir setting was set to sites/remote_site/some_folder/files but stage file proxy was still trying to find the image in sites/default/files on remote. So it seems that the origin_dir setting has no effect at the moment. Only when I changed locally the path to file public folder to sites/remote_site/some_folder/files in settings.local.php with:

$settings['file_public_path'] = 'sites/remote_site/some_folder/files';
the files started proxying correctly.
Comment over 1 year ago →
🇩🇪Germany a.dmitriiev
It seems that other users saw the same problem https://www.drupal.org/project/stage_file_proxy/issues/3396633#comment-1... 🐛 Proxy does not work anymore Fixed and it was fixed in 2.1.x-dev. Maybe a new version will fix the current issue as well.
Comment over 1 year ago →
🇺🇸United States smustgrave
Can this has been fixed in 2.1.x dev branch?
Status changed to Postponed: needs info over 1 year ago2:13pm 13 December 2023
Comment over 1 year ago →
🇺🇸United States smustgrave
Doing a new release for 2.1.x could someone test if this is fixed please.
Merge request !61Issue #3365703: Images not proxied when file_public_path does not match web root → (Closed) created by malcomio
Pipeline finished with Failed
over 1 year ago
Total: 198s
#64440
Status changed to Active over 1 year ago5:21pm 15 December 2023
Comment over 1 year ago →
🇬🇧United Kingdom malcomio
Still observing this on 2.1.3 and 2.1.x - have started a new merge request against 2.1.x

https://git.drupalcode.org/project/stage_file_proxy/-/merge_requests/61#...
Comment 10 months ago →
🇺🇸United States smustgrave
Pipeline finished with Failed
9 months ago
Total: 123s
#221597
Pipeline finished with Canceled
9 months ago
Total: 150s
#221599
Pipeline finished with Failed
9 months ago
Total: 140s
#221602
Status changed to Needs review 9 months ago10:34am 11 July 2024
Comment 9 months ago →
🇬🇧United Kingdom malcomio
Pipeline finished with Failed
9 months ago
Total: 136s
#221663
Status changed to Needs work 9 months ago12:33pm 11 July 2024
Comment 9 months ago →
🇺🇸United States smustgrave
Seems to have failures in the MR
Pipeline finished with Failed
9 months ago
Total: 157s
#221850
Pipeline finished with Failed
9 months ago
#224567
Pipeline finished with Failed
9 months ago
Total: 259s
#224571
Comment 8 months ago →
🇫🇷France Julien Tekrane
julien tekrane → made their first commit to this issue’s fork.
Merge request !803365703-images-not-proxied-3.1.x → (Closed) created by Julien Tekrane
Pipeline finished with Failed
8 months ago
Total: 124s
#251848
Comment 8 months ago →
System Message
julien tekrane → closed merge request !80
Merge request !813365703-images-not-proxied-3.1.x → (Closed) created by Julien Tekrane
Pipeline finished with Success
8 months ago
Total: 167s
#251875
Pipeline finished with Success
8 months ago
Total: 230s
#251873
Comment 8 months ago →
🇫🇷France Julien Tekrane
New MR based on 3.1.x branch

After 3.1.0 release, attached a static https://www.drupal.org/files/issues/2024-08-12/stage_file_proxy-3365703-3.1.0.patch file to be used with composer
Comment 6 months ago →
🇺🇸United States smustgrave
Comment 5 months ago →
System Message
smustgrave → closed merge request !61
Comment 5 months ago →
System Message
smustgrave → closed merge request !38
Status changed to Needs review 5 months ago8:50pm 7 November 2024
Comment 5 months ago →
🇺🇸United States smustgrave
If someone can confirm this addresses the issue for them.
Comment 4 months ago →
🇬🇧United Kingdom malcomio
We've tested the change in merge request 81, and it seems to work as expected.
Comment 4 months ago →
System Message

smustgrave → committed 1539c8cb on 3.1.x
Issue #3365703 by malcomio, julien tekrane, smustgrave, a.dmitriiev,...
Comment 4 months ago →
System Message

smustgrave → committed 1ff925dc on 3.0.x
Issue #3365703 by malcomio, julien tekrane, smustgrave, a.dmitriiev,...
Comment 4 months ago →
System Message
smustgrave → closed merge request !81
Comment 4 months ago →
🇺🇸United States smustgrave
Comment 4 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024