Error when saving text format - configuration property id doesn't exist

I can confirm that I am seeing the same error for a filter format that doesn't have markdown enabled.

Effects 10.3.0 onwards following the addition of the Constraint Validator in Drupal 10.3.

Using Markdown 3.0.1.

Possibly a duplicate of 🐛 Subformstate incorrect interface error Active

I'm also experiencing an issue when saving a text format that does not utilize the markdown filter, see 🐛 Unable to save text format without enabling Markdown filter Active .

I noticed that the commonmark-external-links plugin is marked as deprecated.

This annotation was committed for #3142418: Support multiple libraries per plugin → .

I tried deleting it, and clearing the cache, but got the same error for commonmark-heading-permalink (which isn't marked as deprecated.

Even after applying the patch from the merge request and clearing caches, I'm still getting the fatal error. Is there a step I'm forgetting to get this to work?

Hi, same here. Whenever I try to save a text filter like Full HTML the error happens. Only possibility is to fully disable the markdown module to get it working again. Unfortunately there is no other module which outputs markdown which you can bring in as markdown_easy conflicts on install with the existing markdown-text filter.

Yes we're also seeing the same error - I don't think the issue should have been set to Needs Review.

Have marked the merge request as draft.

With the latest changes in the merge request, this seems to be working as expected.

I think that this may be a side effect of the patch that we're using for ✨ Add support for Commonmark v2 Active - the plugins that seem to be causing this problem are all related to CommonMark.

Ideally we'd address the problem that causes these plugins to be missing an id, rather than just deleting them altogether.

This change seems to cause problems with existing filters that have markdown enabled.

Bumping this to Critical priority since site it breaks the ability for site admins to edit the site's text formats.

From my testing, it appears that the problem occurs when trying to save a text format that has CKeditor 5 configured as the editor. Markdown does NOT need to be enabled on the format at all. So I'm not sure why the validator is even bothering trying to check the Markdown extensions.

It feels like there's some incompatibility with the way the Markdown extensions are defined, or the way they're validated.

After applying the MR34 patch, I was able to save my text format configuration before removing the patch.
I exported the config and got the following diff:

+  markdown:
+    id: filter_null
+    provider: filter
+    status: false
+    weight: -15
+    settings: {  }

while we should have:

+  markdown:
+    id: markdown
+    provider: markdown
+    status: false
+    weight: -15
+    settings: {  }

It might be because ids are missing in markdown.schema.yml

filter_settings.markdown:
  type: markdown.parser
  mapping:
+   id:
+     type: string
+     label: 'Filter ID'
    override:
      type: boolean
      label: 'Override'

We might have to add something like that to all markdown.parser_settings.* and maybe also markdown.extension_settings.*.

Since this file is only used during the module installation, we should use a hook_update somehow

For anyone who is having this problem when trying to edit non-markdown formats, there is a workaround:

1. delete the markdown filter format: drush cdel filter.format.markdown
2, uninstall the markdown module: drush pmu markdown
3. clear cache: drush cr
4. re-enable markdown: drush en markdown
5. re-create the markdown format

In 3463119-abort-validation I've added code to abort validation of the Markdown settings and also remove the Markdown settings from the form state when the markdown filter is not enabled. In my case, this allows a text format with CKEditor enabled but with Markdown disabled to be saved again.

It does not solve the underlying error, because the reported error message is still there when you both enable CKEditor and Markdown. But it looks like they aren't meant to be enabled together.

This should fix 🐛 Unable to save text format without enabling Markdown filter Active as well.