- Issue created by @emircan erkul
- Status changed to Needs review
8 months ago 12:17pm 17 April 2024 - Status changed to Needs work
8 months ago 12:44pm 17 April 2024 - 🇯🇴Jordan Rajab Natshah Jordan
Thanks, Emircan, for reporting and patching!
1. Better to change
bootstrap_barrio_affix
tovartheme_bs4_affix
VARTHEME_BS4_SUBTHEME_affix
in
once('bootstrap_barrio_affix', '[data-toggle="affix"]', context).forEach(function () {
not to have manydata-once
attributes with the samebootstrap_barrio_affix
2. Please, create MR to commit/merge with your --author email as Drupal is not showing the --author anymore - Merge request !7Issue #3441524 by emircanerkul: Fix compatible toggle affix with D10 by switching from jQuery once to drupal/once library → (Merged) created by emircan erkul
- Status changed to Needs review
8 months ago 1:01pm 17 April 2024 - 🇹🇷Turkey emircan erkul Turkey
Hi Rajab, Thanks for the review. Applied your suggestions and created MR.
-
Rajab Natshah →
committed b1b9cea1 on 9.0.x authored by
emircanerkul →
Issue #3441524 by emircanerkul: Fix compatible toggle affix with D10 by...
-
Rajab Natshah →
committed b1b9cea1 on 9.0.x authored by
emircanerkul →
- 🇯🇴Jordan Rajab Natshah Jordan
- Status changed to Fixed
8 months ago 1:30pm 17 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.