[CKEditor5] Missing dependency on drupal.ajax

Can the MR be updated for 11.x

Also steps to reproduce this? May be we need to add a test case.

JeroenT → closed merge request !4192

AFAIS the media library embed button is the only CKEditor 5 button that opens in a dialog. But the media library js files add a dependency on drupal/core.ajax, so you can't reproduce this with this a different CKEditor5 plugin. I ran into this issue while running tests for the entity_embed module.

1. Install Drupal using the minimal installation profile.
2. Enable ckeditor5 and field_ui modules.
3. Create a content type and add a body field using CKEditor 5.
4. Move all fields, except title and body out of the form display (authored by uses Ajax, so adding this field will result in drupal.ajax being loaded.)
5. Add a CKEditor5 plugin that calls the openDialog method. In my case I used Entity embed. So I enabled the entity_embed module and added the default "Node" embed button.
6. Create a new node, click on the embed button. The dialog doesn't open.

I see no harm in loading the library. Will ask the committer if this needs a test though.

I'm not sure why we would have to make this change in core. Shouldn't entity_embed set it as a dependency, not the core CKEditor 5 module? 🤔

I think it does use ajax though unless I'm reading this incorrectly:
https://git.drupalcode.org/project/drupal/-/blob/cb65aa9db0e42b0e0685fec...

I ran into this problem while using entity_embed. But ckeditor5.js is the file that calls Drupal.ajax. So this library should be added here.

Thanks for pointing that out! I had a false memory that we removed it from CKEditor 5... but looks like that isn't the case. 😅 Thanks for the additional information, this makes now total sense 👍

Committed 9c50509 and pushed to 11.x. Thanks! Backported all the way to 9.5.x.

lauriii → closed merge request !4208

🤯

How the hell did we miss this?! 😅🙈

Thanks, great catch!

🙌 Love that easy fix!

Automatically closed - issue fixed for 2 weeks with no activity.