Wrapping drupal-media image in a link produces empty P tags after image

Patch #47 applies to 9.5.3 successfully

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

Want to take a step back and just take a look.

1. Has this been confirmed in ckeditor5?
2. If this is strictly a ckeditor4 issue what is the proposed solution, should be added to the issue summary.

Has this been confirmed in ckeditor5?

I confirmed in comment #26 that this issue is not relevant in CKEditor5 and so is only relevant to CKEditor4.

I suspect that measns this issue should be moved to the CKEditor4 contrib module, unless it will actually get fixed in 9.x (which seems unlikely at this point).

I doubt it. I’m not sure how ckeditor4 fixes are being handled. If we fix in 9.x it will have to be ported then

Confirmed this issue with CKeditor 4, which I suppose is actually new contrib module.

I managed to adapt the solution also used in Entity Embed, as found at #3282295: Additional paragraphs added when embedding an entity in CKEditor and linking it → , and suggested by @Graber above in #37.

The solution was as simple as adding the following lines to the Contrib ckeditor @ modules/contrib/ckeditor/js/plugins/drupalmedialibrary/plugin.js after the existing beforeInit function:

    init: function init(editor) {
      // Prevent adding extra lines.
      editor.dataProcessor.writer.setRules('drupal-media', {
        breakAfterClose: false
      });
    },

This solution is quite a lot simpler than the patch to date on this issue!

Attached patch for the ckeditor contrib

I will say that #53 seems to be working, but I haven't tested it extensively.

I have tested the patch in #53 with Drupal 9.5.9 and it works, being as it is the same solution as provided for Entity Embeds drupal-entity tags it would seem to be the solution to go for.
Though we are still using the ckeditor bundled in the core not the contrib so I had to manually apply the changes to the core version js.

Attached is the version of the patch for the core but using the same fix as #53.

I tested the patch in #53 and it prevents the accumulation of empty p tags, but it is now adding an empty p tag before each media embed that is wrapped in a link/a tag.

In other words, the code should look like this:

<p><a href="#">[drupal embed]</a></p>

But it looks like this:

<p>&nbsp;</p>
<a href="#">[drupal embed]</a>

But like I said, this patch is an improvement as additional p tags aren't added every time you save the node like before.

Since Drupal 9 is End of Life today, I am moving this issue to the contrib module and re-rolling the patch from #55.

#57 wasn't applying. Refactored it for the current 1.0.x branch.

Added the original test back in.

moved the test to the correct file