FileUploadHandler::handleExtensionValidation does not have fallback for sites still using file_validate_extensions

The fix should work, but setting to NW as it needs tests I currently don't have time to add. Hopefully there's a simple Kernel test that can be referenced so it is reasonably easy to make that test.

kim.pepper → made their first commit to this issue’s fork.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Rebased the MR to run the test-only feature

There was 1 failure:
1) Drupal\Tests\file\Kernel\FileUploadHandlerTest::testLegacyExtensions
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
 @expectedDeprecation:
-%A  'file_validate_extensions' is deprecated in drupal:10.2.0 and is removed from drupal:11.0.0. Use the 'FileExtension' constraint instead. See https://www.drupal.org/node/3363700
+

Change seems good but wonder if the CR https://www.drupal.org/node/3363700 → should be updated with this issue?

Left a review on the MR

Would be good to get a draft of the MR changes in the issue summary too, so the committer can make those changes when it is committed.

#11 mentioned change record updates but this issue doesn't have one, so we need one?

Or an issue summary update?

Can we get an issue summary update with the proposed wording changes to the existing CR that the committer can make when this is committed.

@smustgrave I don't think we have any new information to add to the CR. This is a bug where we weren't checking 'file_validate_extensions' for extensions.

Gotcha. Thanks for following up. That case change seems good

Can we get a separate MR for 11.x too?

After 📌 Create an UploadedFile validator and deprecate error checking methods on UploadedFileInterface RTBC the 10.2.x MR doesn't apply

Created a MR for 11.x 😅
Not sure if there are instructions for this somewhere, but this seemed more difficult than I thought.

I think this is safe to put back to RTBC as it was just a re-roll.

Committed to 11.x and 10.2.x

Thanks for the quick turnaround here folks.

larowlan → closed merge request !5117

larowlan → closed merge request !5022

Automatically closed - issue fixed for 2 weeks with no activity.