Create an UploadedFile validator and deprecate error checking methods on UploadedFileInterface

looks good idea!

My only other thought is to not throw exceptions but to use Symfony validators some how. Not sure how this would work. 🤔

Seems like a perfectly reasonable cleanup.

Going to think about the best approach before we commit.

This approach uses a symfony validator that is not coupled with TypeData. It makes use of DrupalTranslator so we still get TranslatableMarkup objects returned from the constraint violation getMessage() method.

I had a go at re-using \Symfony\Component\Validator\Constraints\File and \Symfony\Component\Validator\Constraints\FileValidator but couldn't get the messages to match up due to missing the %file param.

Updated IS with current implementation.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

So reading the IS and CR can't think of a reason not to do this. Going to mark it.

Blocking a critical 📌 [PP-4] Unify file upload logic of REST and JSON:API Postponed therefore this is also critical.

larowlan → closed merge request !4403

Looking good, left some comments on the MR about a possible extra method and some BC issues.

Added a deprecation test for the $throw arg.

All other feedback has been addressed.

All threads have been addressed.

Can we update the change record to add examples for how to fix the deprecation for the $throws param on handleFileUpload and how that works for calling code.

I.e pass FALSE and inspect the errors on the return instead of expecting an exception?

Left a review on the MR too

Resolved all feedback

Appears all threads have been resolved.

This is blocking 4 other issues:

• 📌 Deprecate file_managed_file_save_upload(), file_save_upload() and _file_save_upload_from_form() and replace with a service Needs review
• 📌 Make CKEditor5ImageController reuse FileUploadHandler Active
• 📌 [PP-1] Use BasicRecursiveValidatorFactory for \Drupal\update\ProjectRelease::validateReleaseData() Postponed
• 📌 [PP-1] Move ExecutionContext and ExecutionContextFactory from TypedData to Validation namespace Postponed

Discussed with @catch and @kim.pepper

Because there are still a few moving parts here, I think it makes sense to put this into 11 only, with a goal of it making it into 10.3 with all of the other issues that relate to it (this currently blocks 4 other issues that refactor file upload handling).

Because those 4 issues might require more changes to this, rather than lock ourselves into an API for 10.2, this gives us a chance to get the API right before 10.3

Marking as needs work to re-roll with the deprecations saying 10.3 instead of 10.2. But then I'm keen to get this into 11 and get onto the other issues.

Thanks for your understanding!

Updated all deprecation messages from 10.2 to 10.3.

Moving back to RTBC.

Can we get a second change record for the new basic validator? Thanks

Done ✅

Committed to 11.x and unpostponed the 4 issues.
Published the 2 CRs

larowlan → closed merge request !4477

Automatically closed - issue fixed for 2 weeks with no activity.