field_domain_source_url came from my personal project. I forgot to clean it when I pushed on d.org.
Hi!
LGFM, thx for your contribution. Can you update your MR and add some related functional tests plz?
thx for your report, fixed on v1.0.1-alpha7
Merged, thx for contribution.
Thx for your report.
Fixed. See this commit : https://git.drupalcode.org/project/domain_unique_path_alias/-/commit/ce3...
fixed on 1.x
jenue1933 → made their first commit to this issue’s fork.
Merged, thx for your support!
Hi!
some reviews on your MR.
Can you rebase your branch plz ?
For information, I changed the default branch, now it's 1.x. It's our working branch now.
ok for me, thx!
Thx for your MR. Currently very busy these days, but will check and review next week.
Hi! I completely agree with you. This module needs to populate a domain record for the current nodes after installation.
We should implement a hook_install to handle this. IMO, we should use the field_domain_source data if the domain_source module is installed.
This module provides a single URL for a matching node/domain, while if you use domain_access, there can be multiple domains linked to a single node.
What do you think?
Hi! Thx for your support and this patch!
Can you create a MR plz?
jenue1933 → created an issue.
jenue1933 → created an issue.