Bordeaux
Account created on 23 November 2015, almost 9 years ago
#

Merge Requests

Recent comments

πŸ‡«πŸ‡·France jenue1933 Bordeaux

Merged! Thx for your contribution.

πŸ‡«πŸ‡·France jenue1933 Bordeaux

Thx for your report, I’m currently on holiday, I’ll check your MR next week.

πŸ‡«πŸ‡·France jenue1933 Bordeaux

s1933 β†’ created an issue.

πŸ‡«πŸ‡·France jenue1933 Bordeaux

s1933 β†’ created an issue.

πŸ‡«πŸ‡·France jenue1933 Bordeaux

i will add some information very soon

πŸ‡«πŸ‡·France jenue1933 Bordeaux

field_domain_source_url came from my personal project. I forgot to clean it when I pushed on d.org.

πŸ‡«πŸ‡·France jenue1933 Bordeaux

Hi!

LGFM, thx for your contribution. Can you update your MR and add some related functional tests plz?

πŸ‡«πŸ‡·France jenue1933 Bordeaux

thx for your report, fixed on v1.0.1-alpha7

πŸ‡«πŸ‡·France jenue1933 Bordeaux

Merged, thx for contribution.

πŸ‡«πŸ‡·France jenue1933 Bordeaux

jenue1933 β†’ made their first commit to this issue’s fork.

πŸ‡«πŸ‡·France jenue1933 Bordeaux

Merged, thx for your support!

πŸ‡«πŸ‡·France jenue1933 Bordeaux

Hi!

some reviews on your MR.

Can you rebase your branch plz ?

For information, I changed the default branch, now it's 1.x. It's our working branch now.

πŸ‡«πŸ‡·France jenue1933 Bordeaux

ok for me, thx!

πŸ‡«πŸ‡·France jenue1933 Bordeaux

Thx for your MR. Currently very busy these days, but will check and review next week.

πŸ‡«πŸ‡·France jenue1933 Bordeaux

Hi! I completely agree with you. This module needs to populate a domain record for the current nodes after installation.

We should implement a hook_install to handle this. IMO, we should use the field_domain_source data if the domain_source module is installed.

This module provides a single URL for a matching node/domain, while if you use domain_access, there can be multiple domains linked to a single node.

What do you think?

πŸ‡«πŸ‡·France jenue1933 Bordeaux

Hi! Thx for your support and this patch!

Can you create a MR plz?

Production build 0.71.5 2024