- Issue created by @DieterHolvoet
- π§πͺBelgium DieterHolvoet Brussels
I'm not sure where the
field_domain_source_url
field is supposed to come from. It doesn't seem to be part of the Domain module. I left it out for now, but feel free to add it back if necessary. - π§πͺBelgium DieterHolvoet Brussels
Something else I took the liberty to fix: when decorating a service, you're not supposed to extend the original class. You're supposed to implement the service, inject the original class and call it as a service when necessary. By doing this, you don't need to inject all dependencies the parent needs and the class won't break if the constructor of the parent changes.
- Status changed to Needs review
20 days ago 3:33pm 11 June 2024 - π«π·France jenue1933 Bordeaux
Hi!
LGFM, thx for your contribution. Can you update your MR and add some related functional tests plz?
- π«π·France jenue1933 Bordeaux
field_domain_source_url
came from my personal project. I forgot to clean it when I pushed on d.org.